From: Ian Rogers <irogers@google.com>
To: Sandipan Das <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
eranian@google.com, adrian.hunter@intel.com,
ravi.bangoria@amd.com, ananth.narayan@amd.com
Subject: Re: [PATCH] perf vendor events amd: Fix Zen 4 cache latency events
Date: Fri, 1 Mar 2024 08:39:52 -0800 [thread overview]
Message-ID: <CAP-5=fV49j-fMSF5PcAXP7hoD4guqy8DnQs_uJWcgVM7fKxLhQ@mail.gmail.com> (raw)
In-Reply-To: <20240301084431.646221-1-sandipan.das@amd.com>
On Fri, Mar 1, 2024 at 12:44 AM Sandipan Das <sandipan.das@amd.com> wrote:
>
> L3PMCx0AC and L3PMCx0AD, used in l3_xi_sampled_latency* events, have a
> quirk that requires them to be programmed with SliceId set to 0x3.
> Without this, the events do not count at all and affects dependent
> metrics such as l3_read_miss_latency.
>
> If ThreadMask is not specified, the amd-uncore driver internally sets
> ThreadMask to 0x3, EnAllCores to 0x1 and EnAllSlices to 0x1 but does
> not set SliceId. Since SliceId must also be set to 0x3 in this case,
> specify all the other fields explicitly.
>
> E.g.
>
> $ sudo perf stat -e l3_xi_sampled_latency.all,l3_xi_sampled_latency_requests.all -a sleep 1
>
> Before:
>
> Performance counter stats for 'system wide':
>
> 0 l3_xi_sampled_latency.all
> 0 l3_xi_sampled_latency_requests.all
>
> 1.005155399 seconds time elapsed
>
> After:
>
> Performance counter stats for 'system wide':
>
> 921,446 l3_xi_sampled_latency.all
> 54,210 l3_xi_sampled_latency_requests.all
>
> 1.005664472 seconds time elapsed
>
> Fixes: 5b2ca349c313 ("perf vendor events amd: Add Zen 4 uncore events")
> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
next prev parent reply other threads:[~2024-03-01 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 8:44 [PATCH] perf vendor events amd: Fix Zen 4 cache latency events Sandipan Das
2024-03-01 16:39 ` Ian Rogers [this message]
2024-03-04 18:56 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP-5=fV49j-fMSF5PcAXP7hoD4guqy8DnQs_uJWcgVM7fKxLhQ@mail.gmail.com' \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.