From: Nick Krause <xerofoify@gmail.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: deller@gmx.de, tiwai@suse.de, Jiri Kosina <jkosina@suse.cz>,
Joe Perches <joe@perches.com>,
dave.anglin@bell.net, linux-parisc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parisc: Remove FIXME comment
Date: Fri, 18 Jul 2014 22:25:07 -0400 [thread overview]
Message-ID: <CAPDOMVjScF=7ES7NU=R6sGOmp7QycKX+uMXL-w+1rNEak4G7Dg@mail.gmail.com> (raw)
In-Reply-To: <1405717414.30262.12.camel@dabdike.int.hansenpartnership.com>
On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote:
>> The comment for size of frame not being needed is incorrect , the
>> function called needs this parameter.
>
> Actually, that's not correct. The point of the FIXME is that fram_size
> is only used in a debug print and could be eliminated since the
> internals of the function excluding the debugging statements don't use
> it.
>
> James
>
>
So I need to need a patch removing the parameter from the function
and this part of the code?
Cheers Nick
next prev parent reply other threads:[~2014-07-19 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 20:37 [PATCH] parisc: Remove FIXME comment Nicholas Krause
2014-07-18 20:49 ` Helge Deller
2014-07-18 21:03 ` James Bottomley
2014-07-19 2:25 ` Nick Krause [this message]
2014-07-19 5:20 ` James Bottomley
2014-07-19 5:28 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDOMVjScF=7ES7NU=R6sGOmp7QycKX+uMXL-w+1rNEak4G7Dg@mail.gmail.com' \
--to=xerofoify@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.