From: Ulf Hansson <ulf.hansson@linaro.org>
To: Simon Horman <horms@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v4 0/4] mmc: renesas_sdhi: add eMMC HS400 mode support
Date: Mon, 21 May 2018 16:34:18 +0200 [thread overview]
Message-ID: <CAPDyKFqStqxJtxHroAvufje9gGQ0Q9O3NuH1eBy1RLn66sf5jw@mail.gmail.com> (raw)
In-Reply-To: <20180513082304.uwlyshoevg5wsax2@verge.net.au>
On 13 May 2018 at 10:23, Simon Horman <horms@verge.net.au> wrote:
> Hi Ulf,
>
> On Wed, Apr 18, 2018 at 11:56:56AM +0200, Simon Horman wrote:
>> Hi,
>>
>> this patch-set provides SDHI driver support for eMMC HS400.
>>
>> Based on mmc-v4.17-2
>>
>> Dependencies for applying these patches:
>> * none
>>
>> Dependencies to test eMMC HS400:
>> * [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting
>> * [PATCH v2] arm64: dts: salvator-common: Enable HS400 of SDHI2
>>
>> To assist testing and review this patch and the above mentioned
>> dependencies, which are necessary and sufficient to enable HS400 on H3 /
>> Salvator-X, M3-W 1.0 / Salvator-X and H3 ES2.0 Salvator-XS are available
>> at:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/hs400-v4
>>
>> Changes since v3:
>> * As a follow-up to discussion with Ulf and Wolfram I have proposed
>> two new HS400 tuning host operations. These are provided, and explained,
>> in "mmc: core: more fine-grained hooks for HS400 tuning".
>>
>> The following driver patches have been updated to use these new operations.
>>
>> And "mmc: tmio: add eMMC HS400 mode support" proposes a minor cleanup
>> to make it a little cleaner to add the proposed new host operations to
>> the MMC core.
>
> I am wondering if you could give me some feedback on the approach that I
> have taken here.
>
Simon, apologize for the delay.
I have had a look at the series an overall the approach seems
reasonable to me. The new callbacks makes sense!
However, allow me another day for going into the details.
Kind regards
Uffe
prev parent reply other threads:[~2018-05-21 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 9:56 [PATCH v4 0/4] mmc: renesas_sdhi: add eMMC HS400 mode support Simon Horman
2018-04-18 9:56 ` [PATCH v4 1/4] mmc: core: select HS400 from HS200 tuning function Simon Horman
2018-04-18 9:56 ` [PATCH v4 2/4] mmc: core: more fine-grained hooks for HS400 tuning Simon Horman
2018-05-22 14:32 ` Ulf Hansson
2018-05-28 12:39 ` Simon Horman
2018-04-18 9:56 ` [PATCH v4 3/4] mmc: tmio: add eMMC HS400 mode support Simon Horman
2018-04-18 9:57 ` [PATCH v4 4/4] mmc: renesas_sdhi: " Simon Horman
2018-05-13 8:23 ` [PATCH v4 0/4] " Simon Horman
2018-05-21 14:34 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqStqxJtxHroAvufje9gGQ0Q9O3NuH1eBy1RLn66sf5jw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.