From: Ulf Hansson <ulf.hansson@linaro.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] mmc: tegra: Fix copy-paste error in tegra_sdhci_init_pinctrl_info()
Date: Thu, 06 Sep 2018 06:31:15 +0000 [thread overview]
Message-ID: <CAPDyKFqiLayQ9tAN+oa==JdcButZXucA3k=zmnSwfcoKUxkDog@mail.gmail.com> (raw)
In-Reply-To: <1536145928-15629-1-git-send-email-weiyongjun1@huawei.com>
On 5 September 2018 at 13:12, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> The error code get against a wrong variable. This patch fix it.
>
> Fixes: 5783a9529891 ("mmc: tegra: Reconfigure pad voltages during voltage switching")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks for the patch, however I have already queued a patch in my next
branch fixing this problem.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index e80716c..c789158 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
> pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
> if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
> dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
> - PTR_ERR(tegra_host->pinctrl_state_3v3));
> + PTR_ERR(tegra_host->pinctrl_state_1v8));
> return -1;
> }
>
prev parent reply other threads:[~2018-09-06 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 11:12 [PATCH -next] mmc: tegra: Fix copy-paste error in tegra_sdhci_init_pinctrl_info() Wei Yongjun
2018-09-06 6:31 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqiLayQ9tAN+oa==JdcButZXucA3k=zmnSwfcoKUxkDog@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.