From: Enrico Granata <egranata@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
jasowang@redhat.com, pbonzini@redhat.com,
Stefan Hajnoczi <stefanha@redhat.com>,
axboe@kernel.dk, virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] virtio_blk: Add support for lifetime feature
Date: Tue, 20 Apr 2021 10:28:13 -0600 [thread overview]
Message-ID: <CAPR809tz_2yVvvYUhx629wFJA-+Z67Xx7ZAxNkcwRQbXMm8zvQ@mail.gmail.com> (raw)
In-Reply-To: <20210420060807-mutt-send-email-mst@kernel.org>
I prepared a proposed patch to address these concerns:
https://lists.oasis-open.org/archives/virtio-dev/202104/msg00007.html
Feedback will be much appreciated
Thanks,
- Enrico
On Tue, Apr 20, 2021 at 4:08 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote:
> > Just to despit my 2 cents again: I think the way this is specified
> > in the virtio spec is actively harmful and we should not suport it in
> > Linux.
> >
> > If others override me we at least need to require a detailed
> > documentation of these fields as the virto spec does not provide it.
> >
> > Please also do not add pointless over 80 character lines, and follow
> > the one value per sysfs file rule.
>
> Enrico would you like to raise the issues with the virtio TC
> for resolution?
>
> --
> MST
>
next prev parent reply other threads:[~2021-04-20 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 19:47 [PATCH v2] virtio_blk: Add support for lifetime feature Enrico Granata
2021-04-17 2:42 ` kernel test robot
2021-04-20 7:01 ` Christoph Hellwig
2021-04-20 7:01 ` Christoph Hellwig
2021-04-20 10:08 ` Michael S. Tsirkin
2021-04-20 10:08 ` Michael S. Tsirkin
2021-04-20 16:28 ` Enrico Granata [this message]
2021-04-20 16:41 ` Cornelia Huck
2021-04-20 16:41 ` Cornelia Huck
2021-04-21 15:59 kernel test robot
2021-04-29 10:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPR809tz_2yVvvYUhx629wFJA-+Z67Xx7ZAxNkcwRQbXMm8zvQ@mail.gmail.com \
--to=egranata@google.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.