From: Carlo Arenas <carenas@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] test-lib: fix non-portable pattern bracket expressions
Date: Tue, 12 Feb 2019 02:47:12 -0800 [thread overview]
Message-ID: <CAPUEspg+j+9mm_UX=rNAn-3dmXWNq_Wh3zHjE-PkGfo34405jg@mail.gmail.com> (raw)
In-Reply-To: <20190212003446.GF13301@sigill.intra.peff.net>
On Mon, Feb 11, 2019 at 4:35 PM Jeff King <peff@peff.net> wrote:
>
> Ah, doubly puzzling. It works fine in my Debian dash (but fnmatch was
> enabled in 0.5.8-1 there, too).
FWIW, it is reported by both checkbashisms and shellcheck if "linting"
could be considered of help to track these kind of issues.
other "portability" issues seem safe, mainly because they are either silly
(like the use of local) or meant to be used only with bash (as on the mingw
specific functions or the bash version check that was broken recently for
NetBSD) but the functions run_with_limited_{cmdline,stack} that use `ulimit -s`
might be worth looking into
Carlo
prev parent reply other threads:[~2019-02-12 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 11:50 [PATCH] test-lib: make '--stress' more bisect-friendly SZEDER Gábor
2019-02-08 16:47 ` Jeff King
2019-02-08 16:49 ` Jeff King
2019-02-08 18:33 ` SZEDER Gábor
2019-02-08 19:12 ` Jeff King
2019-02-08 18:23 ` SZEDER Gábor
2019-02-08 19:11 ` Jeff King
2019-02-11 19:58 ` [PATCH] test-lib: fix non-portable pattern bracket expressions SZEDER Gábor
2019-02-11 22:29 ` Junio C Hamano
2019-02-11 23:46 ` Jeff King
2019-02-12 0:30 ` SZEDER Gábor
2019-02-12 0:34 ` Jeff King
2019-02-12 10:47 ` Carlo Arenas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEspg+j+9mm_UX=rNAn-3dmXWNq_Wh3zHjE-PkGfo34405jg@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.