From: Dan Williams <dan.j.williams@intel.com>
To: Oliver O'Halloran <oohall@gmail.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 3/4] ndctl/namespace: Use seed alignment as the default
Date: Sun, 25 Nov 2018 12:14:23 -0800 [thread overview]
Message-ID: <CAPcyv4gWW5XWX+NHeaaG0s2tz30tYgzYf8icRNqE0k4jCSKGqQ@mail.gmail.com> (raw)
In-Reply-To: <20181119080056.13386-3-oohall@gmail.com>
On Mon, Nov 19, 2018 at 12:11 AM Oliver O'Halloran <oohall@gmail.com> wrote:
>
> When creating a pfn or dax namespace ndctl uses a default alignment of 2MB
> when the user does not explicitly supply one. This works on most systems
> (x86, ARM, PPC64 with radix MMU), but it fails when the kernel does not
> support a 2MB page size (PPC64 with hash MMU).
>
> This patch makes ndctl use the alignment of the relevant seed namespace as
> the default instead. The kernel will always pick a valid default alignment
> so this should be a bit more portable.
Looks ok, but I'd want to try it with the unit test suite after my
comment on patch-2 is resolved.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-11-25 20:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 8:00 [PATCH 1/4] libndctl: Use the supported_alignment attribute Oliver O'Halloran
2018-11-19 8:00 ` [PATCH 2/4] ndctl/namespace: Check for seed namespaces earlier Oliver O'Halloran
2018-11-25 20:12 ` Dan Williams
2018-11-27 13:27 ` Oliver
2019-01-08 2:59 ` Dan Williams
2019-01-08 11:00 ` Oliver
2018-11-19 8:00 ` [PATCH 3/4] ndctl/namespace: Use seed alignment as the default Oliver O'Halloran
2018-11-25 20:14 ` Dan Williams [this message]
2018-11-19 8:00 ` [PATCH 4/4] ndctl/namespace: Validate alignment from the {pfn|dax} seed Oliver O'Halloran
2018-11-25 20:18 ` Dan Williams
2018-11-25 20:06 ` [PATCH 1/4] libndctl: Use the supported_alignment attribute Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4gWW5XWX+NHeaaG0s2tz30tYgzYf8icRNqE0k4jCSKGqQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.