From: Dan Williams <dan.j.williams@intel.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: Ross Zwisler <zwisler@kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] acpi/nfit: remove duplicate set nd_set in acpi_nfit_init_interleave_set()
Date: Sun, 13 Jan 2019 20:41:11 -0800 [thread overview]
Message-ID: <CAPcyv4h7DeZmoRMxNpC2nGCWHJEw_QOy2J6nev037Ywtd-NTKQ@mail.gmail.com> (raw)
In-Reply-To: <20190114021929.3658-1-richardw.yang@linux.intel.com>
On Sun, Jan 13, 2019 at 6:19 PM Wei Yang <richardw.yang@linux.intel.com> wrote:
>
> We allocate nd_set in acpi_nfit_init_interleave_set() and assignn it to
> ndr_desc, while the assignment is done twice in this function.
>
> This patch removes the second assignment. No functional change.
I think it makes more sense to remove the first assignment. Don't let
an uninitialized nd_set escape that routine. Either ->nd_set is left
NULL or it points to an initialized instance instead of potentially a
zeroed one.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-01-14 4:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 2:19 [PATCH] acpi/nfit: remove duplicate set nd_set in acpi_nfit_init_interleave_set() Wei Yang
2019-01-14 4:41 ` Dan Williams [this message]
2019-01-15 3:04 ` Wei Yang
2019-01-15 3:09 ` [PATCH v2] " Wei Yang
2019-01-15 3:13 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4h7DeZmoRMxNpC2nGCWHJEw_QOy2J6nev037Ywtd-NTKQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=richardw.yang@linux.intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.