Re: [PATCH] libnvdimm/security: fix nvdimm_security_state() state request selection

From: Dan Williams <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] libnvdimm/security: fix nvdimm_security_state() state request selection
Date: Tue, 15 Jan 2019 10:30:38 -0800	[thread overview]
Message-ID: <CAPcyv4hETYMqsuMjUd_LyHNd2w5R4Chftp_E-81gOKMfOj_OKg@mail.gmail.com> (raw)
In-Reply-To: <154757678148.35482.4492154450935271566.stgit@djiang5-desk3.ch.intel.com>

On Tue, Jan 15, 2019 at 10:26 AM Dave Jiang <dave.jiang@intel.com> wrote:
>
> The input parameter should be enum nvdimm_passphrase_type instead of bool
> for selection of master/user for selection of extended master passphrase
> state or the regular user passphrase state.
>
> Fixes: 89fa9d8ea7bdf ("acpi/nfit, libnvdimm/security: add Intel DSM 1.8 master passphrase support")
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/nvdimm/nd-core.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h
> index 2b2cf4e554d3..e5ffd5733540 100644
> --- a/drivers/nvdimm/nd-core.h
> +++ b/drivers/nvdimm/nd-core.h
> @@ -54,12 +54,12 @@ struct nvdimm {
>  };
>
>  static inline enum nvdimm_security_state nvdimm_security_state(
> -               struct nvdimm *nvdimm, bool master)
> +               struct nvdimm *nvdimm, enum nvdimm_passphrase_type ptype)
>  {
>         if (!nvdimm->sec.ops)
>                 return -ENXIO;
>
> -       return nvdimm->sec.ops->state(nvdimm, master);
> +       return nvdimm->sec.ops->state(nvdimm, ptype);
>  }

Ok, applied.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm