From: Dan Williams <dan.j.williams@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: Dave Chinner <david@fromorbit.com>,
linux-block@vger.kernel.org, Jan Kara <jack@suse.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 7/7] mm, dax: unmap dax mappings at bdev shutdown
Date: Mon, 30 Nov 2015 14:03:44 -0800 [thread overview]
Message-ID: <CAPcyv4i6gvjzEEb0+ZdoRFGUDPXKj=_NLdyaZZi2pwXdyBUK9Q@mail.gmail.com> (raw)
In-Reply-To: <20151125183736.12508.86178.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Nov 25, 2015 at 10:37 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> Currently dax mappings leak past / survive block_device shutdown. While
> page cache pages are permitted to be read/written after the block_device
> is torn down this is not acceptable in the dax case as all media access
> must end when the device is disabled. The pfn backing a dax mapping is
> permitted to be invalidated after bdev shutdown and this is indeed the
> case with brd.
>
> When a dax capable block_device driver calls del_gendisk_queue() in its
> shutdown path it needs to ensure that all DAX pfns are unmapped, and
> that no new mappings can be established. This is different than the
> pagecache backed case where the disk is protected by the queue being
> torn down which ends I/O to the device. Since dax bypasses the page
> cache we need to unconditionally unmap the inode.
>
> Cc: Jan Kara <jack@suse.com>
> Cc: Dave Chinner <david@fromorbit.com>
> Cc: Matthew Wilcox <willy@linux.intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> [honza: drop changes to truncate_inode_pages_final]
> [honza: ensure mappings can't be re-established]
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
Dave, can this patch move forward while we figure out ->shutdown() for
super_operations?
next prev parent reply other threads:[~2015-11-30 22:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 18:36 [PATCH v2 0/7] dax cleanups and lifetime fixes Dan Williams
2015-11-25 18:37 ` [PATCH v2 1/7] pmem, dax: clean up clear_pmem() Dan Williams
2015-11-25 18:37 ` [PATCH v2 2/7] dax: increase granularity of dax_clear_blocks() operations Dan Williams
2015-11-25 18:37 ` [PATCH v2 3/7] dax: guarantee page aligned results from bdev_direct_access() Dan Williams
2015-11-25 18:37 ` [PATCH v2 4/7] dax: fix lifetime of in-kernel dax mappings with dax_map_atomic() Dan Williams
2015-11-25 18:37 ` [PATCH v2 5/7] fs: notify superblocks of backing-device death Dan Williams
2015-11-25 21:50 ` Dave Chinner
2015-11-25 22:09 ` Dan Williams
2015-11-26 6:27 ` Dave Chinner
2015-11-26 7:11 ` Dan Williams
2015-12-01 4:03 ` Dave Chinner
2015-12-01 4:20 ` Dan Williams
2015-11-25 18:37 ` [PATCH v2 6/7] ext4: skip inode dirty when backing device is gone Dan Williams
2015-11-25 18:37 ` [PATCH v2 7/7] mm, dax: unmap dax mappings at bdev shutdown Dan Williams
2015-11-30 22:03 ` Dan Williams [this message]
2015-12-01 4:21 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4i6gvjzEEb0+ZdoRFGUDPXKj=_NLdyaZZi2pwXdyBUK9Q@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.