From: Song Liu <song@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCHv2 bpf-next 2/2] selftests/bpf: Add more uprobe multi fail tests
Date: Mon, 18 Dec 2023 08:19:11 -0800 [thread overview]
Message-ID: <CAPhsuW551fE2Fy=8HLAYJkvttZPaC-hT+nwgrDeHQzwvdZ+6XQ@mail.gmail.com> (raw)
In-Reply-To: <20231217215538.3361991-3-jolsa@kernel.org>
On Sun, Dec 17, 2023 at 1:56 PM Jiri Olsa <jolsa@kernel.org> wrote:
>
> We fail to create uprobe if we pass negative offset,
> adding test for that plus some more.
nit: "negative offset plus some more" is a little weird to me. This is more
like "testing error handling paths of uprobe multi creation".
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Other than the nit,
Acked-by: Song Liu <song@kernel.org>
next prev parent reply other threads:[~2023-12-18 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 21:55 [PATCHv2 bpf-next 0/2] bpf: Add check for negative uprobe multi offset Jiri Olsa
2023-12-17 21:55 ` [PATCHv2 bpf-next 1/2] bpf: Fail uprobe multi link with negative offset Jiri Olsa
2023-12-18 16:12 ` Song Liu
2023-12-18 17:56 ` Andrii Nakryiko
2023-12-19 8:33 ` Jiri Olsa
2023-12-17 21:55 ` [PATCHv2 bpf-next 2/2] selftests/bpf: Add more uprobe multi fail tests Jiri Olsa
2023-12-18 16:19 ` Song Liu [this message]
2023-12-18 17:53 ` Andrii Nakryiko
2023-12-18 18:10 ` [PATCHv2 bpf-next 0/2] bpf: Add check for negative uprobe multi offset patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW551fE2Fy=8HLAYJkvttZPaC-hT+nwgrDeHQzwvdZ+6XQ@mail.gmail.com' \
--to=song@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.