From: Song Liu <song@kernel.org>
To: Kyle Huey <me@kylehuey.com>
Cc: Kyle Huey <khuey@kylehuey.com>,
linux-kernel@vger.kernel.org,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Marco Elver <elver@google.com>,
Yonghong Song <yonghong.song@linux.dev>,
"Robert O'Callahan" <robert@ocallahan.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v3 1/4] perf/bpf: Call bpf handler directly, not through overflow machinery
Date: Tue, 2 Jan 2024 14:56:03 -0800 [thread overview]
Message-ID: <CAPhsuW6VqD=zie6Y6JPALp3egMSYWF6UysS+bQG_61t=6v4fxQ@mail.gmail.com> (raw)
In-Reply-To: <20231211045543.31741-2-khuey@kylehuey.com>
On Sun, Dec 10, 2023 at 8:55 PM Kyle Huey <me@kylehuey.com> wrote:
>
> To ultimately allow bpf programs attached to perf events to completely
> suppress all of the effects of a perf event overflow (rather than just the
> sample output, as they do today), call bpf_overflow_handler() from
> __perf_event_overflow() directly rather than modifying struct perf_event's
> overflow_handler. Return the bpf program's return value from
> bpf_overflow_handler() so that __perf_event_overflow() knows how to
> proceed. Remove the now unnecessary orig_overflow_handler from struct
> perf_event.
>
> This patch is solely a refactoring and results in no behavior change.
>
> Signed-off-by: Kyle Huey <khuey@kylehuey.com>
> Suggested-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Song Liu <song@kernel.org>
next prev parent reply other threads:[~2024-01-02 22:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 4:55 [PATCH v3 0/4] Combine perf and bpf for fast eval of hw breakpoint conditions Kyle Huey
2023-12-11 4:55 ` [PATCH v3 1/4] perf/bpf: Call bpf handler directly, not through overflow machinery Kyle Huey
2023-12-11 14:20 ` Marco Elver
2023-12-11 15:20 ` Kyle Huey
2024-01-02 22:56 ` Song Liu [this message]
2024-01-02 23:05 ` Song Liu
2024-01-19 0:07 ` Kyle Huey
2023-12-11 4:55 ` [PATCH v3 2/4] perf/bpf: Remove unneeded uses_default_overflow_handler Kyle Huey
2023-12-11 4:55 ` Kyle Huey
2023-12-12 9:22 ` Will Deacon
2023-12-12 9:22 ` Will Deacon
2024-01-02 22:56 ` Song Liu
2024-01-02 22:56 ` Song Liu
2023-12-11 4:55 ` [PATCH v3 3/4] perf/bpf: Allow a bpf program to suppress all sample side effects Kyle Huey
2024-01-02 23:10 ` Song Liu
2023-12-11 4:55 ` [PATCH v3 4/4] selftest/bpf: Test a perf bpf program that suppresses " Kyle Huey
2024-01-02 22:49 ` Song Liu
2024-01-19 0:08 ` Kyle Huey
2023-12-13 1:38 ` [PATCH v3 0/4] Combine perf and bpf for fast eval of hw breakpoint conditions Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW6VqD=zie6Y6JPALp3egMSYWF6UysS+bQG_61t=6v4fxQ@mail.gmail.com' \
--to=song@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=elver@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=khuey@kylehuey.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robert@ocallahan.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.