All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: jpewhacker@gmail.com
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] send-email: explicitly disable authentication
Date: Fri, 19 Oct 2018 10:10:36 -0400	[thread overview]
Message-ID: <CAPig+cRFZ3kvbrUJpQheSFTvdah0Pds8boF0vf-p94SeWoUE+g@mail.gmail.com> (raw)
In-Reply-To: <9dc2995ff84158450255478c7411339a81f63aba.camel@gmail.com>

On Thu, Oct 18, 2018 at 6:02 PM Joshua Watt <jpewhacker@gmail.com> wrote:
> On Thu, 2018-10-18 at 17:53 -0400, Eric Sunshine wrote:
> > On Thu, Oct 18, 2018 at 5:16 PM Joshua Watt <jpewhacker@gmail.com>
> > wrote:
> > Implementation complexity aside, spelling the option --no-smtp-auth
> > might be more intuitive and consistent than --smtp-auth=none.
>
> One advantage of --smtp-auth=none is that it can also be done with a
> config variable sendemail.smtpauth="none". Would be also add a config
> variable like sendemail.nosmtpauth (the negative seems strange to me)?

I would not expect to see a "negating" config variable like that. I
was just suggesting that a "--no-*" command-line option might be more
intuitive.

> Or maybe --no-smtp-auth is just a shorthand alias for --smtp-auth=none?

That's one possibility.

  reply	other threads:[~2018-10-19 14:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 21:15 [PATCH] send-email: explicitly disable authentication Joshua Watt
2018-10-18 21:53 ` Eric Sunshine
2018-10-18 22:01   ` Joshua Watt
2018-10-19 14:10     ` Eric Sunshine [this message]
2018-10-22 17:52 ` [PATCH v2] " Joshua Watt
2018-10-22 18:03   ` Joshua Watt
2018-10-23  0:32   ` Junio C Hamano
2018-10-23  2:40     ` Joshua Watt
2018-10-23  3:24   ` [PATCH v3] " Joshua Watt
2018-10-25  9:43     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRFZ3kvbrUJpQheSFTvdah0Pds8boF0vf-p94SeWoUE+g@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=jpewhacker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.