All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stone <daniel@fooishbar.org>
To: "Smith, Gary K" <gary.k.smith@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Render decompression support for Gen9 and above
Date: Tue, 22 Mar 2016 13:30:45 +0000	[thread overview]
Message-ID: <CAPj87rPKicWHU9Rezd2VvcA7xfjxyBQzDMhvEnEjy6Nf8aSytQ@mail.gmail.com> (raw)
In-Reply-To: <591D9F2F8137E144B6CDD649149EA82D1B4E2C22@IRSMSX103.ger.corp.intel.com>

Hi Gary,

On 21 March 2016 at 12:20, Smith, Gary K <gary.k.smith@intel.com> wrote:
> What are the objections to this change?

Exactly the same as the last time we discussed it: that you're abusing
plane properties to contain fundamental properties of the buffer you
want to scan out, i.e. that which naturally belongs in the framebuffer
object rather than a separate plane property. And doing it in a way
which is prone to failure when userspace is unaware of these
properties too.

That being said, I hadn't noticed that this had moved to being a
purely Intel-private property, rather than touching Android core at
all, so if you can get it past the Intel DRM maintainers, then fine. I
was primarily watching out for core DRM.

Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-22 13:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 16:50 [PATCH 1/2] drm: Add aux plane verification in addFB2 Vandana Kannan
2016-03-18 16:50 ` [PATCH 2/2] drm/i915: Render decompression support for Gen9 and above Vandana Kannan
2016-03-18 17:05   ` Daniel Stone
2016-03-21 12:20     ` Smith, Gary K
2016-03-22 13:30       ` Daniel Stone [this message]
2016-03-22 13:36         ` Daniel Stone
2016-03-22 14:59           ` Smith, Gary K
2016-03-18 17:12   ` Ville Syrjälä
2016-04-25  5:00     ` Kannan, Vandana
2016-04-29 14:57       ` [PATCH v2 " Vandana Kannan
2016-04-29 14:45         ` Ville Syrjälä
2016-05-09  6:02           ` Kannan, Vandana
2016-05-13 14:04             ` [PATCH v3 " Vandana Kannan
2016-05-24 11:05               ` Kannan, Vandana
2016-03-18 16:54 ` [PATCH 1/2] drm: Add aux plane verification in addFB2 Ville Syrjälä
2016-03-21 10:58 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2016-04-29 14:34 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Add aux plane verification in addFB2 (rev2) Patchwork
2016-05-13 13:42 ` ✗ Ro.CI.BAT: failure for series starting with [1/2] drm: Add aux plane verification in addFB2 (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPj87rPKicWHU9Rezd2VvcA7xfjxyBQzDMhvEnEjy6Nf8aSytQ@mail.gmail.com \
    --to=daniel@fooishbar.org \
    --cc=gary.k.smith@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.