From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jacob Keller <jacob.keller@gmail.com>
Subject: RE: [PATCH v3] name-rev: use generation numbers if available
Date: Thu, 10 Mar 2022 01:25:25 +0000 [thread overview]
Message-ID: <CO1PR11MB5089439F5FBB755C67049AC5D60B9@CO1PR11MB5089.namprd11.prod.outlook.com> (raw)
In-Reply-To: <xmqqilsmir41.fsf@gitster.g>
> -----Original Message-----
> From: Junio C Hamano <gitster@pobox.com>
> Sent: Wednesday, March 09, 2022 4:33 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: git@vger.kernel.org; Jacob Keller <jacob.keller@gmail.com>
> Subject: Re: [PATCH v3] name-rev: use generation numbers if available
>
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
> > +# A-B-C-D-E-main
> > +#
> > +# Where C has a non-monotonically increasing commit timestamp w.r.t. other
> > +# commits
> > +test_expect_success 'non-monotonic commit dates setup' '
> > + UNIX_EPOCH_ZERO="@0 +0000" &&
> > + git init non-monotonic &&
> > + test_commit -C non-monotonic A &&
> > + test_commit -C non-monotonic --no-tag B &&
> > + test_commit -C non-monotonic --no-tag --date "$UNIX_EPOCH_ZERO" C
> &&
> > + test_commit -C non-monotonic D &&
> > + test_commit -C non-monotonic E
> > +'
> > +
> > +test_expect_success 'name-rev with commitGraph handles non-monotonic
> timestamps' '
> > + test_config -C non-monotonic core.commitGraph false &&
>
> Don't you mean "true" here?
>
Yep. Will fix.
> > + (
> > + cd non-monotonic &&
> > +
> > + echo "main~3 tags/D~2" >expect &&
> > + git name-rev --tags main~3 >actual &&
> > +
> > + test_cmp expect actual
> > + )
> > +'
>
> Other than that there wasn't anything unexpected in this iteration.
>
> Thanks.
next prev parent reply other threads:[~2022-03-10 1:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 0:05 [PATCH v3] name-rev: use generation numbers if available Jacob Keller
2022-03-10 0:33 ` Junio C Hamano
2022-03-10 1:25 ` Keller, Jacob E [this message]
2022-03-10 1:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5089439F5FBB755C67049AC5D60B9@CO1PR11MB5089.namprd11.prod.outlook.com \
--to=jacob.e.keller@intel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.