From: "Kaliszczuk, Leszek" <leszek.kaliszczuk@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Saleem, Shiraz" <shiraz.saleem@intel.com>,
"Ertman, David M" <david.m.ertman@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] ice: Don't use GFP_KERNEL in atomic context
Date: Mon, 28 Feb 2022 15:07:33 +0000 [thread overview]
Message-ID: <CY4PR1101MB2101D3A3815052A2BD52D600EE019@CY4PR1101MB2101.namprd11.prod.outlook.com> (raw)
In-Reply-To: <40c94af2f9140794351593047abc95ca65e4e576.1642358759.git.christophe.jaillet@wanadoo.fr>
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, January 16, 2022 7:46 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Saleem, Shiraz <shiraz.saleem@intel.com>; Ertman,
> David M <david.m.ertman@intel.com>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe
> JAILLET <christophe.jaillet@wanadoo.fr>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org
> Subject: [PATCH] ice: Don't use GFP_KERNEL in atomic context
>
> ice_misc_intr() is an irq handler. It should not sleep.
>
> Use GFP_ATOMIC instead of GFP_KERNEL when allocating some memory.
>
> Fixes: 348048e724a0 ("ice: Implement iidc operations")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> I've never played a lot with irq handler. My understanding is that they should never
> sleep. So GFP_KERNEL must be avoided. So I guess that this patch is correct.
>
> However, I don't know if some special cases allow such allocation.
> Any feedback/pointer to a good doc/explanation is welcome :)
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Leszek Kaliszczuk <leszek.kaliszczuk@intel.com>
prev parent reply other threads:[~2022-02-28 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 18:46 [PATCH] ice: Don't use GFP_KERNEL in atomic context Christophe JAILLET
2022-01-16 18:46 ` [Intel-wired-lan] " Christophe JAILLET
2022-01-16 21:42 ` Andrew Lunn
2022-01-16 21:42 ` [Intel-wired-lan] " Andrew Lunn
2022-01-18 20:01 ` Christophe JAILLET
2022-01-18 20:01 ` [Intel-wired-lan] " Christophe JAILLET
2022-02-28 15:07 ` Kaliszczuk, Leszek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB2101D3A3815052A2BD52D600EE019@CY4PR1101MB2101.namprd11.prod.outlook.com \
--to=leszek.kaliszczuk@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.