RE: [PATCH 0/4] Enable amd-pstate active mode by default

From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"Huang, Ray" <Ray.Huang@amd.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Robert Moore <robert.moore@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"devel@acpica.org" <devel@acpica.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"Karny, Wyes" <Wyes.Karny@amd.com>,
	"Yuan, Perry" <Perry.Yuan@amd.com>
Subject: RE: [PATCH 0/4] Enable amd-pstate active mode by default
Date: Mon, 5 Jun 2023 16:07:27 +0000	[thread overview]
Message-ID: <CYYPR12MB8655C41A0DE7938EBF44DFCF9C4DA@CYYPR12MB8655.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230605151133.2615-1-mario.limonciello@amd.com>

[AMD Official Use Only - General]

Hi Mario, Raphael,

> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@amd.com>
> Sent: Monday, June 5, 2023 11:11 PM
> To: Huang, Ray <Ray.Huang@amd.com>; Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com>
> Cc: Rafael J . Wysocki <rafael@kernel.org>; Len Brown <lenb@kernel.org>;
> Viresh Kumar <viresh.kumar@linaro.org>; Robert Moore
> <robert.moore@intel.com>; linux-acpi@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-pm@vger.kernel.org; devel@acpica.org; Shenoy,
> Gautham Ranjal <gautham.shenoy@amd.com>; Karny, Wyes
> <Wyes.Karny@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; Limonciello,
> Mario <Mario.Limonciello@amd.com>
> Subject: [PATCH 0/4] Enable amd-pstate active mode by default
>
> Active mode for amd-pstate has shown enough success now that it makes
> sense to enable it by default on client systems.
>
> This series introduces a new kernel configuration option to set the default
> policy for amd-pstate modes for a kernel.
>
> Server systems will by identified by the PM preferred profile and still be set as
> disabled by default for now.
>
> Mario Limonciello (4):
>   ACPI: CPPC: Add a symbol to check if the preferred profile is a server
>   cpufreq: amd-pstate: Set a fallback policy based on preferred_profile
>   cpufreq: amd-pstate: Add a kernel config option to set default mode
>   cpufreq: intel_pstate: Use the acpi_pm_profile_server() symbol
>
>  drivers/acpi/cppc_acpi.c       | 34 +++++++++++++++
>  drivers/cpufreq/Kconfig.x86    | 17 ++++++++
>  drivers/cpufreq/amd-pstate.c   | 80 ++++++++++++++++++++++------------
>  drivers/cpufreq/intel_pstate.c | 17 +-------
>  include/acpi/actbl.h           |  3 +-
>  include/acpi/processor.h       | 10 +++++
>  include/linux/amd-pstate.h     |  4 +-
>  7 files changed, 121 insertions(+), 44 deletions(-)
>
> --
> 2.34.1

The series is tested with commit 7736c431466abb54a2679dc257f739fddfa84295 (linux-pm/bleeding-edge)

Default option will enable EPP mode without any parameters added to kernel command line,
If user adds "amd_pstate=passive" to kernel command line, they still can choose other modes to use.

Based the testing result.
Tested-by: Yuan Perry <Perry.Yuan@amd.com>

Perry.