From: "Prashant Laddha (prladdha)" <prladdha@cisco.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [RFC PATCH] fixp-arith: replace sin/cos table by a better precision one
Date: Wed, 17 Dec 2014 08:17:38 +0000 [thread overview]
Message-ID: <D0B737F7.270AE%prladdha@cisco.com> (raw)
In-Reply-To: <f437103f284c4ed964bd6577ff0c7793e8299d52.1418743646.git.mchehab@osg.samsung.com>
Thanks for the patch, Mauro. Just a correction below.
>
>+/* cos(x) = sin(x + pi radians) */
>+
This should pi / 2. Correcting for the same below.
>+#define fixp_cos32_rad(rad, twopi) \
>+ fixp_sin32_rad(rad + twopi/2, twopi)
fixp_sin32_rad(rad + twopi/4, twopi)
>+
I think this patch will serve the need. I will test it for vivid sir tone
generation. I will rework my patches to use sin/cos functions from
fixp-arith.h.
>
next prev parent reply other threads:[~2014-12-17 8:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1418635162-8814-1-git-send-email-prladdha@cisco.com>
2014-12-15 9:19 ` [PATCH 1/6] Use LUT based implementation for (co)sine functions Prashant Laddha
2014-12-15 9:24 ` Improvements in (co)sine generation in vivid sdr Prashant Laddha (prladdha)
2014-12-15 13:13 ` [PATCH 1/6] Use LUT based implementation for (co)sine functions Mauro Carvalho Chehab
2014-12-15 13:30 ` Antti Palosaari
2014-12-16 6:41 ` Prashant Laddha (prladdha)
2014-12-16 10:45 ` Mauro Carvalho Chehab
2014-12-16 11:40 ` Mauro Carvalho Chehab
2014-12-16 15:30 ` [RFC PATCH] fixp-arith: replace sin/cos table by a better precision one Mauro Carvalho Chehab
2014-12-17 8:17 ` Prashant Laddha (prladdha) [this message]
2014-12-17 13:42 ` [RFC PATCHv2] " Mauro Carvalho Chehab
2014-12-17 19:11 ` Prashant Laddha (prladdha)
2014-12-17 21:54 ` Mauro Carvalho Chehab
2014-12-15 9:19 ` [PATCH 2/6] Vivid sine gen: Optimization for sine LUT size Prashant Laddha
2014-12-15 9:19 ` [PATCH 3/6] Vivid sine gen: Refactor get_sin_val () Prashant Laddha
2014-12-15 9:19 ` [PATCH 4/6] Vivid sine gen: Renamed SIN_TAB_SIZE to SIN_LUT_SIZE Prashant Laddha
2014-12-15 9:19 ` [PATCH 5/6] Vivid: Increased precision for (co)sine computation Prashant Laddha
2014-12-15 9:19 ` [PATCH 6/6] Vivid SDR: Modified equation used for generating FM Prashant Laddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0B737F7.270AE%prladdha@cisco.com \
--to=prladdha@cisco.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.