From: "Javier González" <jg@lightnvm.io>
To: "Matias Bjørling" <mb@lightnvm.io>
Cc: "Matias Bjørling" <m@bjorling.me>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] lightnvm: remove mlc pairs structure
Date: Thu, 1 Feb 2018 09:56:42 +0800 [thread overview]
Message-ID: <D1CC1A53-9A57-4162-ADBF-45F0BDD519C0@lightnvm.io> (raw)
In-Reply-To: <e807b046-7d83-9cea-377c-03eb6fd1f662@lightnvm.io>
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]
> On 31 Jan 2018, at 16.35, Matias Bjørling <mb@lightnvm.io> wrote:
>
> On 01/31/2018 03:00 AM, Javier González wrote:
>>> On 30 Jan 2018, at 21.26, Matias Bjørling <m@bjorling.me> wrote:
>>>
>>> The known implementations of the 1.2 specification, and upcoming 2.0
>>> implementation all expose a sequential list of pages to write.
>>> Remove the data structure, as it is no longer needed.
>>>
>>> Signed-off-by: Matias Bjørling <m@bjorling.me>
>>> ---
>>> drivers/nvme/host/lightnvm.c | 14 +-------------
>>> 1 file changed, 1 insertion(+), 13 deletions(-)
>> Even though the current implementations does not use the MLC pairing
>> information, this is part of the on the 1.2 identification. Until we
>> eventually remove 1.2 support (if we do), the identify structure should
>> reflect the specification as is.
>> Javier
>
> I already started on removing the MLC bits in previous patches. These
> two patches continue that trend. I don't know of any implementing
> either multiple groups or MLC, and since it has not been implemented
> before, no one is going to use it. No reason to have dead code hanging
> around. This is similar to the NVMe device driver not having
> definitions for all that is in the specification until it is used in
> the implementation.
It's ok with me - just wanted to point out that it seems weird removing
bits from the structure that describes the 1.2 identify command. Guess
these can com back if someone ever needs them...
Javier
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-02-01 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 13:26 [PATCH 1/2] lightnvm: remove mlc pairs structure Matias Bjørling
2018-01-30 13:26 ` [PATCH 2/2] lightnvm: remove multiple groups in 1.2 data structure Matias Bjørling
2018-01-31 2:02 ` Javier González
2018-01-31 2:00 ` [PATCH 1/2] lightnvm: remove mlc pairs structure Javier González
2018-01-31 8:35 ` Matias Bjørling
2018-02-01 1:56 ` Javier González [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1CC1A53-9A57-4162-ADBF-45F0BDD519C0@lightnvm.io \
--to=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bjorling.me \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.