From: Biwen Li <biwen.li@nxp.com>
To: Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
"Biwen Li (OSS)" <biwen.li@oss.nxp.com>
Cc: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jiafei Pan <jiafei.pan@nxp.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc
Date: Tue, 22 Sep 2020 03:31:28 +0000 [thread overview]
Message-ID: <DB6PR0401MB243883AEA75F615A0768D03E8F3B0@DB6PR0401MB2438.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VE1PR04MB6687237BD5D137C4B9EC6DBD8F3B0@VE1PR04MB6687.eurprd04.prod.outlook.com>
>
>
>
> > -----Original Message-----
> > From: Biwen Li <biwen.li@nxp.com>
> > Sent: Monday, September 21, 2020 10:13 PM
> > To: Shawn Guo <shawnguo@kernel.org>; Biwen Li (OSS)
> > <biwen.li@oss.nxp.com>
> > Cc: alexandre.belloni@bootlin.com; Leo Li <leoyang.li@nxp.com>;
> > robh+dt@kernel.org; mark.rutland@arm.com; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; linux-
> > rtc@vger.kernel.org
> > Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove
> > useless property of rtc
> >
> > >
> > > Caution: EXT Email
> > >
> > > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > > From: Biwen Li <biwen.li@nxp.com>
> > > >
> > > > Remove useless property interrupts of rtc
> > > >
> > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > > ---
> > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > > > 1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > index dce79018d397..e9e982176e07 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > @@ -171,8 +171,6 @@
> > > > rtc@51 {
> > > > compatible = "nxp,pcf2129";
> > > > reg = <0x51>;
> > > > - // IRQ10_B
> > > > - interrupts = <0 150 0x4>;
> > >
> > > If it's a correct description of hardware, I do not see why we would
> > > need to remove it.
> > Hi Shawn,
> >
> > Don't need use the interrupt, only read time from rtc.
>
> User probably will choose to use the alarm feature of the RTC and need the
> interrupt property. Is there any issue when the interrupt property is present?
Generic interrupt controller on layerscape only support IRQ_TYPE_LEVEL_HIGH and IRQ_TYPE_EDGE_RISING(except SoC LS1043A, LS1046A),
Not support IRQ_TYPE_LEVEL_LOW,
In drivers/rtc/rtc-pcf2127.c
ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
pcf2127_rtc_irq,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
dev_name(dev), dev);
>
> >
> > Best Regards,
> > Biwen Li
> > >
> > > Shawn
> > >
> > > > };
> > > > };
> > > >
> > > > --
> > > > 2.17.1
> > > >
next prev parent reply other threads:[~2020-09-22 3:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 7:32 [PATCH 1/5] rtc: pcf2127: fix a bug when not specify interrupts property Biwen Li
2020-09-15 7:32 ` [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc Biwen Li
2020-09-22 3:02 ` Shawn Guo
2020-09-22 3:12 ` [EXT] " Biwen Li
2020-09-22 3:28 ` Leo Li
2020-09-22 3:31 ` Biwen Li [this message]
2020-09-22 22:28 ` Li Yang
2020-09-15 7:32 ` [PATCH 3/5] arm64: dts: ls1088a-rdb: " Biwen Li
2020-09-15 7:32 ` [PATCH 4/5] arm64: dts : ls1088a-qds: " Biwen Li
2020-09-15 7:32 ` [PATCH 5/5] arm64: dts: ls1046a-qds: " Biwen Li
2020-09-15 10:26 ` [PATCH 1/5] rtc: pcf2127: fix a bug when not specify interrupts property Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0401MB243883AEA75F615A0768D03E8F3B0@DB6PR0401MB2438.eurprd04.prod.outlook.com \
--to=biwen.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.