From: Kai Heng Feng <kai.heng.feng@canonical.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, andy@infradead.org,
Mario Limonciello <mario.limonciello@dell.com>,
tiwai@suse.com, platform-driver-x86@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query
Date: Fri, 9 Mar 2018 16:14:03 +0800 [thread overview]
Message-ID: <DC881209-6C71-4B13-BF48-05F1F93E207A@canonical.com> (raw)
In-Reply-To: <20180308163837.myfmnowz5ogto52w@pali>
> On Mar 9, 2018, at 12:38 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
>
> On Thursday 08 March 2018 17:10:22 Kai-Heng Feng wrote:
>> +int dell_switchable_gfx_enabled(bool *enabled);
>
> What about following API?
>
> bool dell_switchable_gfx_is_enabled(void);
>
> Are you really interested in errors? Then what about?
Not really. We can assume it's false when there's any error.
I'll update the function in next version, thanks!
Kai-Heng
>
> int dell_switchable_gfx_is_enabled(void);
>
> with e.g.
> < 0 - error
> = 0 - disabled
>> 0 - enabled
>
> --
> Pali Rohár
> pali.rohar@gmail.com
next prev parent reply other threads:[~2018-03-09 8:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 9:10 [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h Kai-Heng Feng
2018-03-08 9:10 ` [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query Kai-Heng Feng
2018-03-08 16:38 ` Pali Rohár
2018-03-08 16:38 ` Pali Rohár
2018-03-09 8:14 ` Kai Heng Feng [this message]
2018-03-08 9:10 ` [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics Kai-Heng Feng
2018-03-08 9:38 ` [alsa-devel] " Lukas Wunner
2018-03-08 10:38 ` Kai Heng Feng
2018-03-08 10:38 ` Kai Heng Feng
2018-03-08 11:30 ` [alsa-devel] " Lukas Wunner
2018-03-08 11:30 ` Lukas Wunner
2018-03-09 8:22 ` [alsa-devel] " Kai Heng Feng
2018-03-09 9:02 ` Pali Rohár
2018-03-09 9:02 ` Pali Rohár
2018-03-09 9:30 ` Kai Heng Feng
2018-03-09 9:34 ` Mario.Limonciello
2018-03-09 9:34 ` Mario.Limonciello
2018-03-09 9:46 ` Pali Rohár
2018-03-09 9:46 ` Pali Rohár
2018-03-09 9:59 ` Mario.Limonciello
2018-03-09 9:59 ` Mario.Limonciello
2018-03-10 10:38 ` Pali Rohár
2018-03-10 10:38 ` Pali Rohár
2018-03-11 14:03 ` Mario.Limonciello
2018-03-11 14:03 ` Mario.Limonciello
2018-03-11 14:30 ` Pali Rohár
2018-03-11 14:30 ` Pali Rohár
2018-03-12 1:30 ` Mario.Limonciello
2018-03-12 1:30 ` Mario.Limonciello
2018-03-13 7:56 ` Kai Heng Feng
2018-03-13 7:56 ` Kai Heng Feng
2018-03-13 8:13 ` Mario.Limonciello
2018-03-13 8:13 ` Mario.Limonciello
2018-03-10 6:50 ` Lukas Wunner
2018-03-10 6:50 ` Lukas Wunner
2018-03-10 10:40 ` Pali Rohár
2018-03-10 10:40 ` Pali Rohár
2018-03-11 14:06 ` Mario.Limonciello
2018-03-11 14:06 ` Mario.Limonciello
2018-03-13 8:24 ` Kai Heng Feng
2018-04-07 16:44 ` [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h Darren Hart
2018-04-07 16:44 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC881209-6C71-4B13-BF48-05F1F93E207A@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.