RE: [RFC 5/5] vfio/qat: Add vfio_pci driver for Intel QAT VF devices

From: "Zeng, Xin" <xin.zeng@intel.com>
To: Brett Creeley <bcreeley@amd.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>,
	"andriy.shevchenko@linux.intel.com" 
	<andriy.shevchenko@linux.intel.com>,
	"Cao, Yahui" <yahui.cao@intel.com>
Subject: RE: [RFC 5/5] vfio/qat: Add vfio_pci driver for Intel QAT VF devices
Date: Thu, 24 Aug 2023 07:31:26 +0000	[thread overview]
Message-ID: <DM4PR11MB55021A7ECD9DAB45C246A9DC881DA@DM4PR11MB5502.namprd11.prod.outlook.com> (raw)
In-Reply-To: <10f3159d-62ae-0e4c-8ba4-6f7819a47ecb@amd.com>

On Thursday, August 17, 2023 12:20 AM, Brett Creeley <bcreeley@amd.com> wrote:
> > +{
> > +       struct device *dev = &pdev->dev;
> > +       struct qat_vf_core_device *qat_vdev;
> > +       int ret;
> > +
> > +       qat_vdev = vfio_alloc_device(qat_vf_core_device, core_device.vdev,
> dev, &qat_vf_pci_ops);
> > +       if (IS_ERR(qat_vdev))
> > +               return PTR_ERR(qat_vdev);
> > +
> > +       qat_vdev->vf_id = pci_iov_vf_id(pdev);
> > +       qat_vdev->parent = pdev->physfn;
> > +       if (!qat_vdev->parent || qat_vdev->vf_id < 0)
> > +               return -EINVAL;
> 
> Since vfio_alloc_device() was successful you need to call
> vfio_put_device() in this error case as well.

Good catch, will fix it. 
Thanks for the comment, Brett.

> > +
> > +       pci_set_drvdata(pdev, &qat_vdev->core_device);
> > +       ret = vfio_pci_core_register_device(&qat_vdev->core_device);
> > +       if (ret)
> > +               goto out_put_device;
> > +
> > +       return 0;
> > +
> > +out_put_device:
> > +       vfio_put_device(&qat_vdev->core_device.vdev);
> > +       return ret;
> > +}
> > +
> > +static struct qat_vf_core_device *qat_vf_drvdata(struct pci_dev *pdev)
> > +{
> > +       struct vfio_pci_core_device *core_device = pci_get_drvdata(pdev);
> > +
> > +       return container_of(core_device, struct qat_vf_core_device,
> core_device);
> > +}
> > +
> > +

> > +MODULE_LICENSE("GPL");
> > +MODULE_AUTHOR("Intel Corporation");
> > +MODULE_DESCRIPTION("QAT VFIO PCI - VFIO PCI driver with live
> migration support for Intel(R) QAT device family");
> > --
> > 2.18.2
> >