From: Avri Altman <Avri.Altman@wdc.com>
To: Peter Wang <peter.wang@mediatek.com>
Cc: "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"wsd_upstream@mediatek.com" <wsd_upstream@mediatek.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"alice.chao@mediatek.com" <alice.chao@mediatek.com>,
"cc.chou@mediatek.com" <cc.chou@mediatek.com>,
"chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
"jiajie.hao@mediatek.com" <jiajie.hao@mediatek.com>
Subject: RE: [PATCH v4] scsi: ufs-mediatek: fix ufs power down specs violation
Date: Thu, 13 May 2021 08:15:26 +0000 [thread overview]
Message-ID: <DM6PR04MB65755B434F899F5F05E8F957FC519@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1620892726.21658.3.camel@mtkswgap22>
> > > + if (ufshcd_is_link_off(hba))
> > > + ufs_mtk_device_reset_ctrl(0, res);
> > According to your commit log, you should call reset just before
> > ufs_mtk_vreg_set_lpm, or turn phy off, whichever turn off vcc -
> > Few lines above.
> >
> > Thanks,
> > Avri
>
> ufs_mtk_vreg_set_lpm only set vccq2 power mode to lpm, dose't trun off
> vccq2.And turn phy off is also turn off vcc, dose't turn off vccq2.
> RST_N keep high is no problem when we trun off vcc and vccq2 keep on.
> But RST_N will got problem if we trun off vccq2.
> (RST_N signal should be between VSS(Ground) and VCCQ/VCCQ2)
> Here set RST_N to low is after shut down pm set link off, and before
> shutdown pm turn off vccq2.
OK. Thanks for clarifying this.
Thanks,
Avri
>
> Thanks
> Peter
>
> >
> > > +
> > > return 0;
> > > fail:
> > > /*
> > > --
> > > 1.7.9.5
> >
next prev parent reply other threads:[~2021-05-13 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 10:01 [PATCH v4] scsi: ufs-mediatek: fix ufs power down specs violation peter.wang
2021-05-12 10:01 ` [PATCH] " peter.wang
2021-05-12 10:11 ` [PATCH v4] " Stanley Chu
2021-05-13 6:45 ` Avri Altman
2021-05-13 7:58 ` Peter Wang
2021-05-13 8:15 ` Avri Altman [this message]
2021-05-15 3:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB65755B434F899F5F05E8F957FC519@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.