Re: [PATCH v7 00/11] libata cleanups and improvements

From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v7 00/11] libata cleanups and improvements
Date: Wed, 18 Aug 2021 09:54:15 +0000	[thread overview]
Message-ID: <DM6PR04MB7081B8F072CF016FE63017A1E7FF9@DM6PR04MB7081.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210816014456.2191776-1-damien.lemoal@wdc.com

On 2021/08/16 10:45, Damien Le Moal wrote:
> The first three patches of this series fix sparse and kernel bot
> warnings (potential NULL pointer dereference and locking imbalance).
> 
> The following three patches cleanup libata-core code in the area of
> device configuration (ata_dev_configure() function).
> 
> Patch 7 improves ata_read_log_page() to avoid unnecessary warning
> messages and patch 8 adds an informational message on device scan to
> advertize the features supported by a device.
> 
> Path 9 adds the new sysfs ahci device attribute ncq_prio_supported to
> indicate that a disk supports NCQ priority.
> 
> Patch 10 and 11 update the ABI user documentation files.

Hi Jens,

Can you queue this minus patch 1 please ? I can resend v8 without patch 1 too if
needed. Thanks !

> 
> Changes from v6:
> * Added patch 10 and 11
> 
> Changes from v5:
> * Updated patch 9 to include adding the new ncq_prio_supported sysfs
>   attribute for SATA adapters other than AHCI. Changed the patch title
>   and commit message accordingly.
> 
> Changes from v4:
> * Fixed patch 1 to avoid an out-of-bounds array access
> * Changed title of patch 3 to describe the change (as opposed to only
>   mentioning the tool that found the problem)
> * Removed patch 10 from this series as Martin took it through the scsi
>   tree
> * Added reviewed-by tags
> 
> Changes from v3:
> * Reworked patch 1
> * Added patch 3 to fix a sparse warning discovered while checking
>   patch 1 & 2
> * Added reviewed-by tags
> 
> Changes from v2:
> * Reworked patch 4 to avoid the need for an additional on-stack string
>   for device information messages
> * Added reviewed-by tags
> 
> Changes from v1:
> * Added patch 1 and 2 to fix problems reported by the kernel test robot
> * Use strscpy() instead of strcpy in patch 4
> * Use sysfs_emit in patch 8 and 9 as suggested by Bart
> * Fix typos in comments of the new sas_ncq_prio_supported attribute in
>   patch 9
> 
> Damien Le Moal (10):
>   libata: fix ata_host_alloc_pinfo()
>   libata: fix ata_host_start()
>   libata: simplify ata_scsi_rbuf_fill()
>   libata: cleanup device sleep capability detection
>   libata: cleanup ata_dev_configure()
>   libata: cleanup NCQ priority handling
>   libata: fix ata_read_log_page() warning
>   libata: print feature list on device scan
>   libata: Introduce ncq_prio_supported sysfs sttribute
>   docs: sysfs-block-device: document ncq_prio_supported
> 
> Niklas Cassel (1):
>   docs: sysfs-block-device: improve ncq_prio_enable documentation
> 
>  Documentation/ABI/testing/sysfs-block-device |  43 ++-
>  drivers/ata/libahci.c                        |   1 +
>  drivers/ata/libata-core.c                    | 290 ++++++++++---------
>  drivers/ata/libata-sata.c                    |  62 ++--
>  drivers/ata/libata-scsi.c                    |  60 +---
>  include/linux/libata.h                       |   5 +
>  6 files changed, 252 insertions(+), 209 deletions(-)
> 

-- 
Damien Le Moal
Western Digital Research