All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Saarinen, Jani" <jani.saarinen@intel.com>
To: Dave Airlie <airlied@gmail.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 00/23] i915/display: split and constify vtable (v3)
Date: Thu, 9 Sep 2021 07:17:46 +0000	[thread overview]
Message-ID: <DM8PR11MB56559E47F6B27EA3CF85E772E0D59@DM8PR11MB5655.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210909015322.2988500-1-airlied@gmail.com>

Hi, 

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Dave Airlie
> Sent: torstai 9. syyskuuta 2021 4.53
> To: intel-gfx@lists.freedesktop.org
> Cc: jani.nikula@linux.intel.com
> Subject: [Intel-gfx] [PATCH 00/23] i915/display: split and constify vtable (v3)
> 
> (v3 just adds some missing ,)
> 
>       Details below, I've taken all the review feedback (thanks Jani).
> I added 3 patches moving to wrappers before refactoring, and one other patch is
> unreviewed (07) but the main comment was wanting the wrappers.
> 
> Jani if you are happy with the final 4 patches can you land this series, I don't think I
> have drm-intel commit rights.
Not right Jani to answer but in my view CI in not healthy at all if looking from: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20995/index.html? 
See taints in the boot. 

> 
> v1:
> This is orthogonal to my display ptr refactoring and should probably be applied first.
> 
> The display funcs vtable was a bit of mess, lots of intermixing of internal display
> functionality and interfaces to watermarks/irqs.
> 
> It's also considered not great security practice to leave writeable function pointers
> around for exploits to get into.
> 
> This series attempts to address both problems, first there are a few cleanups, then it
> splits the function table into multiple pieces.
> Some of the splits might be bikesheds but I think we should apply first and merge
> things later if there is good reason.
> 
> The second half converts all the vtables to static const structs, I've used macros in
> some of them to make it less messy, the cdclk one is probably the worst one.
> 
> v2:
> Added some patches adding wrappers around things before refactoring them as
> suggested by Jani.
> Fixed up all struct names as suggested by Jani.
> Added s-o-b lines
> Added commit msgs.
> 
> v3:
> added missing , (Jani)
> 
> Dave.
> 


      parent reply	other threads:[~2021-09-09  7:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  1:52 [Intel-gfx] [PATCH 00/23] i915/display: split and constify vtable (v3) Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 01/23] drm/i915/pm: drop get_fifo_size vfunc Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 02/23] drm/i915: make update_wm take a dev_priv Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 03/23] drm/i915/wm: provide wrappers around watermark vfuncs calls Dave Airlie
2021-09-09  8:48   ` Jani Nikula
2021-09-09  1:53 ` [Intel-gfx] [PATCH 04/23] drm/i915: add wrappers around cdclk vtable funcs Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 05/23] drm/i915/display: add intel_fdi_link_train wrapper Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 06/23] drm/i915: split clock gating init from display vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 07/23] drm/i915: split watermark vfuncs " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 08/23] drm/i915: split color functions " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 09/23] drm/i915: split audio " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 10/23] drm/i915: split cdclk " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 11/23] drm/i915: split irq hotplug function " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 12/23] drm/i915: split fdi link training " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 13/23] drm/i915: split the dpll clock compute out " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 14/23] drm/i915: constify fdi link training vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 15/23] drm/i915: constify hotplug function vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 16/23] drm/i915: constify color " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 17/23] drm/i915: constify the audio " Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 18/23] drm/i915: constify the dpll clock vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 19/23] drm/i915: constify the cdclk vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 20/23] drm/i915: drop unused function ptr and comments Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 21/23] drm/i915: constify display function vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 22/23] drm/i915: constify clock gating init vtable Dave Airlie
2021-09-09  1:53 ` [Intel-gfx] [PATCH 23/23] drm/i915: constify display wm vtable Dave Airlie
2021-09-09  2:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915/display: split and constify vtable (rev3) Patchwork
2021-09-09  2:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-09-09  2:28 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-09-09  7:17 ` Saarinen, Jani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB56559E47F6B27EA3CF85E772E0D59@DM8PR11MB5655.namprd11.prod.outlook.com \
    --to=jani.saarinen@intel.com \
    --cc=airlied@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.