From: Bernhard Beschow <shentey@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
mst@redhat.com, marcel.apfelbaum@gmail.com, imammedo@redhat.com,
ani@anisinha.ca, aurelien@aurel32.net, pbonzini@redhat.com,
richard.henderson@linaro.org, eduardo@habkost.net,
hpoussin@reactos.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 00/12] hw/acpi/piix4: remove legacy piix4_pm_init() function
Date: Sun, 29 May 2022 18:31:21 +0000 [thread overview]
Message-ID: <E07C8017-374B-4B4A-8902-074E50D0B1AA@gmail.com> (raw)
In-Reply-To: <d56db423-6d8f-d2ca-c91b-d098ed9f4549@amsat.org>
Am 29. Mai 2022 18:05:41 UTC schrieb "Philippe Mathieu-Daudé" <f4bug@amsat.org>:
>On 28/5/22 11:19, Mark Cave-Ayland wrote:
>> Whilst reviewing Bernhard's PIIX Southbridge QOMifcation patches at
>> https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg04329.html, I
>> noticed that we should first eliminate the legacy device init function
>> piix4_pm_init().
>>
>> This series moves the outstanding logic from piix4_pm_init() into the
>> relevant instance init() and realize() functions, changes the IRQs to
>> use qdev gpios, and then finally removes the now-unused piix4_pm_initfn()
>> function.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>
>>
>> Mark Cave-Ayland (12):
>> hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to
>> piix4_pm_realize()
>> hw/acpi/piix4: change smm_enabled from int to bool
>> hw/acpi/piix4: convert smm_enabled bool to qdev property
>> hw/acpi/piix4: move PIIX4PMState into separate piix4.h header
>> hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMState
>> hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn()
>> hw/acpi/piix4: introduce piix4_pm_init() instance init function
>> hw/acpi/piix4: use qdev gpio to wire up sci_irq
>> hw/acpi/piix4: use qdev gpio to wire up smi_irq
>> hw/i386/pc_piix: create PIIX4_PM device directly instead of using
>> piix4_pm_initfn()
>> hw/isa/piix4.c: create PIIX4_PM device directly instead of using
>> piix4_pm_initfn()
>> hw/acpi/piix4: remove unused piix4_pm_initfn() function
>
>Nitpicking, SCI could also be a named GPIO :)
Yes... I was just wondering the same!
Best regards,
Bernhard
>
>Series:
>Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-05-29 18:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 9:19 [PATCH 00/12] hw/acpi/piix4: remove legacy piix4_pm_init() function Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 01/12] hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to piix4_pm_realize() Mark Cave-Ayland
2022-05-30 4:48 ` Ani Sinha
2022-05-28 9:19 ` [PATCH 02/12] hw/acpi/piix4: change smm_enabled from int to bool Mark Cave-Ayland
2022-05-30 4:56 ` Ani Sinha
2022-05-30 11:22 ` Philippe Mathieu-Daudé via
2022-05-28 9:19 ` [PATCH 03/12] hw/acpi/piix4: convert smm_enabled bool to qdev property Mark Cave-Ayland
2022-05-30 5:18 ` Ani Sinha
2022-05-28 9:19 ` [PATCH 04/12] hw/acpi/piix4: move PIIX4PMState into separate piix4.h header Mark Cave-Ayland
2022-05-29 19:02 ` Bernhard Beschow
2022-05-28 9:19 ` [PATCH 05/12] hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMState Mark Cave-Ayland
2022-05-29 18:24 ` Bernhard Beschow
2022-05-30 20:10 ` Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 06/12] hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn() Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 07/12] hw/acpi/piix4: introduce piix4_pm_init() instance init function Mark Cave-Ayland
2022-05-29 19:06 ` Bernhard Beschow
2022-05-30 10:44 ` Philippe Mathieu-Daudé via
2022-05-30 20:24 ` Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 08/12] hw/acpi/piix4: use qdev gpio to wire up sci_irq Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 09/12] hw/acpi/piix4: use qdev gpio to wire up smi_irq Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 10/12] hw/i386/pc_piix: create PIIX4_PM device directly instead of using piix4_pm_initfn() Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 11/12] hw/isa/piix4.c: " Mark Cave-Ayland
2022-05-28 9:19 ` [PATCH 12/12] hw/acpi/piix4: remove unused piix4_pm_initfn() function Mark Cave-Ayland
2022-05-29 18:05 ` [PATCH 00/12] hw/acpi/piix4: remove legacy piix4_pm_init() function Philippe Mathieu-Daudé via
2022-05-29 18:31 ` Bernhard Beschow [this message]
2022-05-30 20:02 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E07C8017-374B-4B4A-8902-074E50D0B1AA@gmail.com \
--to=shentey@gmail.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.