RE: [PATCH v6 00/35] drm/i915: Implement HDCP2.2

From: "Shankar, Uma" <uma.shankar@intel.com>
To: "C, Ramalingam" <ramalingam.c@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"seanpaul@chromium.org" <seanpaul@chromium.org>,
	"Winkler, Tomas" <tomas.winkler@intel.com>,
	"Usyskin, Alexander" <alexander.usyskin@intel.com>
Subject: RE: [PATCH v6 00/35] drm/i915: Implement HDCP2.2
Date: Mon, 30 Jul 2018 09:09:20 +0000	[thread overview]
Message-ID: <E7C9878FBA1C6D42A1CA3F62AEB6945F7F36131B@BGSMSX104.gar.corp.intel.com> (raw)
In-Reply-To: <1531538117-1606-1-git-send-email-ramalingam.c@intel.com>

>-----Original Message-----
>From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of
>Ramalingam C
>Sent: Saturday, July 14, 2018 8:45 AM
>To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
>daniel@ffwll.ch; seanpaul@chromium.org; Winkler, Tomas
><tomas.winkler@intel.com>; Usyskin, Alexander <alexander.usyskin@intel.com>;
>Shankar, Uma <uma.shankar@intel.com>
>Subject: [PATCH v6 00/35] drm/i915: Implement HDCP2.2
>
>The sequence for HDCP2.2 authentication and encryption is implemented in I915.
>Encoder specific implementations are moved into hdcp_shim.
>
>Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces a client
>driver for mei bus, so that for HDCP2.2 authentication, HDCP2.2 stack in I915 can
>avail the services from ME FW.
>
>DRM_I915 selects INTEL_MEI_HDCP, which selects INTEL_MEI_ME and
>INTEL_MEI. If we are interested in disabling the MEI_HDCP and MEI Bus then we
>need an option to disable the HDCP2.2 in I915 (like DRM_I915_HDCP2.2!?). Till
>then they are binded.

I feel it would be good to have a config to control HDCP2.2 instead of having such a
strong binding with MEI. If MEI have some issues we don’t want I915 to go down even
if HDCP is not even required or used for a particular distribution or a design.
@Daniel/Sean - What do you suggest ?

>
>Userspace interface remains unchanged as version agnostic. When userspace
>request for HDCP enable, Kernel will detect the HDCP source and sink's HDCP
>version(1.4/2.2)capability and enable the best capable version for that
>combination.
>
>This series enables the HDCP2.2 for Type0 content streams.
>Thanks a lot for Daniel Vetter and Sean Paul for reviewing v5.
>
>Major Changes in v6:
>  - Component master is added in I915_load [Daniel].
>  - I915 load will wait until all associated components are loaded.
>	[Daniel]
>  - Many review comments from Sean Paul and Daniel Vetter are addressed.
>  - Few patches are merged together. [Sean Paul]
>  - Gmbus changes for burst read is already merged.
>
>Complete series is hosted at
>	https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v6
>
>Ramalingam C (34):
>  drm: hdcp2.2 authentication msg definitions
>  drm: HDMI and DP specific HDCP2.2 defines
>  linux/mei: Header for mei_hdcp driver interface
>  drm/i915: wrapping all hdcp var into intel_hdcp
>  drm/i915: Define Intel HDCP2.2 registers
>  component: alloc component_match without any comp to match
>  drm/i915: component master at i915 driver load
>  drm/i915: Initialize HDCP2.2 and its MEI interface
>  drm/i915: Pullout the bksv read and validation
>  drm/i915: Enable and Disable of HDCP2.2
>  drm/i915: Implement HDCP2.2 receiver authentication
>  drm/i915: Implement HDCP2.2 repeater authentication
>  drm/i915: Implement HDCP2.2 link integrity check
>  drm/i915: Handle HDCP2.2 downstream topology change
>  drm/i915: hdcp_check_link only on CP_IRQ
>  drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ
>  drm/i915: Implement the HDCP2.2 support for DP
>  drm/i915: Implement the HDCP2.2 support for HDMI
>  drm/i915: Add HDCP2.2 support for DP connectors
>  drm/i915: Add HDCP2.2 support for HDMI connectors
>  misc/mei/hdcp: Client driver for HDCP application
>  misc/mei/hdcp: Component framework for I915 Interface
>  misc/mei/hdcp: Define ME FW interface for HDCP2.2
>  misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
>  misc/mei/hdcp: Verify Receiver Cert and prepare km
>  misc/mei/hdcp: Verify H_prime
>  misc/mei/hdcp: Store the HDCP Pairing info
>  misc/mei/hdcp: Initiate Locality check
>  misc/mei/hdcp: Verify L_prime
>  misc/mei/hdcp: Prepare Session Key
>  misc/mei/hdcp: Repeater topology verification and ack
>  misc/mei/hdcp: Verify M_prime
>  misc/mei/hdcp: Enabling the HDCP authentication
>  misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
>
>Tomas Winkler (1):
>  mei: bus: whitelist hdcp client
>
> drivers/base/component.c             |   30 +
> drivers/gpu/drm/i915/i915_drv.c      |   87 ++-
> drivers/gpu/drm/i915/i915_drv.h      |    3 +
> drivers/gpu/drm/i915/i915_reg.h      |   32 +
> drivers/gpu/drm/i915/intel_display.c |    6 +-
> drivers/gpu/drm/i915/intel_dp.c      |  345 ++++++++++-
> drivers/gpu/drm/i915/intel_drv.h     |   92 ++-
> drivers/gpu/drm/i915/intel_hdcp.c    | 1107
>+++++++++++++++++++++++++++++++---
> drivers/gpu/drm/i915/intel_hdmi.c    |  192 +++++-
> drivers/misc/mei/Kconfig             |    7 +
> drivers/misc/mei/Makefile            |    2 +
> drivers/misc/mei/bus-fixup.c         |   16 +
> drivers/misc/mei/hdcp/Makefile       |    6 +
> drivers/misc/mei/hdcp/mei_hdcp.c     |  857 ++++++++++++++++++++++++++
> drivers/misc/mei/hdcp/mei_hdcp.h     |  408 +++++++++++++
> include/drm/drm_dp_helper.h          |   51 ++
> include/drm/drm_hdcp.h               |  237 ++++++++
> include/drm/i915_component.h         |   76 +++
> include/linux/component.h            |    2 +
> include/linux/mei_hdcp.h             |  100 +++
> 20 files changed, 3559 insertions(+), 97 deletions(-)  create mode 100644
>drivers/misc/mei/hdcp/Makefile  create mode 100644
>drivers/misc/mei/hdcp/mei_hdcp.c  create mode 100644
>drivers/misc/mei/hdcp/mei_hdcp.h  create mode 100644
>include/linux/mei_hdcp.h
>
>--
>2.7.4
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel