All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Li, Liang Z" <liang.z.li@intel.com>
To: Ladi Prosek <lprosek@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status
Date: Mon, 8 Aug 2016 07:32:22 +0000	[thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E04219917@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CABdb734v0-z47n_sL7dh7AGS8osnSbXO6pnL43U2m_kQpogQig@mail.gmail.com>

> >
> > Hi Liang,
> >
> > I should be able to look into it this week if you help me with testing.
> >
> > Thanks,
> > Ladi
> 
> Please try the attached patch. I have tested it with a simple 'migrate' to save
> the state and then '-incoming' to load it back.
> 

Thanks for your work. I have already saw your v3 patch, so I will test that  one.

> One question for you: is it expected that stats_poll_interval is not preserved
> by save/load? I had to explicitly set guest-stats-polling-interval on the

Yes, I found that too. And I am not quite sure about that. IMO,
' stats_poll_interval ' should be treated as part of device state as well as the
' stats_vq_elem ', but they are not contained at the very beginning.

> receiving VM to start getting stats again. It's also the reason why the new
> virtio_balloon_receive_stats call is not under if
> (balloon_stats_enabled(s)) because this condition always evaluates to false
> for me.

Thanks!
Liang

      parent reply	other threads:[~2016-08-08  7:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06  2:36 [Qemu-devel] [PATCH v2] balloon: Fix failure of updating guest memory status Liang Li
2016-07-06  8:55 ` Michael S. Tsirkin
2016-07-06  9:23   ` Li, Liang Z
2016-07-06 10:32     ` Michael S. Tsirkin
2016-07-06 12:49       ` Li, Liang Z
2016-07-06 13:40         ` Michael S. Tsirkin
2016-08-01 23:59           ` Li, Liang Z
2016-08-02  0:11             ` Michael S. Tsirkin
2016-08-03  7:25               ` Ladi Prosek
2016-08-04 15:14                 ` Ladi Prosek
2016-08-04 16:01                   ` Michael S. Tsirkin
2016-08-04 19:45                     ` Ladi Prosek
2016-08-08  7:32                   ` Li, Liang Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F2CBF3009FA73547804AE4C663CAB28E04219917@shsmsx102.ccr.corp.intel.com \
    --to=liang.z.li@intel.com \
    --cc=dgilbert@redhat.com \
    --cc=lprosek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.