Re: [PATCH v3 1/3] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.

From: Paul Cercueil <paul@crapouillou.net>
To: 周琰杰 <zhouyanjie@wanyeetech.com>
Cc: gregkh@linuxfoundation.org, hminas@synopsys.com,
	robh+dt@kernel.org, krzk+dt@kernel.org,
	tsbogend@alpha.franken.de, linux-usb@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, dragancecavac@yahoo.com,
	hns@goldelico.com, dongsheng.qiu@ingenic.com,
	aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
	sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
	reimu@sudomaker.com
Subject: Re: [PATCH v3 1/3] dt-bindings: dwc2: Add bindings for new Ingenic SoCs.
Date: Sat, 16 Apr 2022 17:34:31 +0100	[thread overview]
Message-ID: <J1YFAR.2881WOMSYUZM2@crapouillou.net> (raw)
In-Reply-To: <1649964337-114337-2-git-send-email-zhouyanjie@wanyeetech.com>

Hi Zhou,

Le ven., avril 15 2022 at 03:25:35 +0800, 周琰杰 (Zhou Yanjie) 
<zhouyanjie@wanyeetech.com> a écrit :
> Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000
> SoC, the X1600 SoC, the X1700 SoC, the X1830 SoC, and the X2000 SoC
> from Ingenic.
> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> 
> Notes:
>     v1->v2:
>     Add Rob Herring's Acked-by.
> 
>     v2->v3:
>     No change.
> 
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml 
> b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 4cebce6..c6e8c0b 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -17,6 +17,13 @@ properties:
>      oneOf:
>        - const: brcm,bcm2835-usb
>        - const: hisilicon,hi6220-usb
> +      - const: ingenic,jz4775-otg
> +      - const: ingenic,jz4780-otg
> +      - const: ingenic,x1000-otg

The driver handles the JZ4775, JZ4780 and X1000 the exact same way. 
Maybe the latter two should use the JZ4775 string as the fallback? Do 
you know if the IP cores are any different?

> +      - const: ingenic,x1600-otg
> +      - const: ingenic,x1700-otg
> +      - const: ingenic,x1830-otg

Same here (and btw, first time I hear about the X1600 and X1700 ;))

Cheers,
-Paul

> +      - const: ingenic,x2000-otg
>        - items:
>            - const: rockchip,rk3066-usb
>            - const: snps,dwc2
> --
> 2.7.4
> 