From: Michal Kalderon <mkalderon@marvell.com>
To: Kamal Heib <kamalheib1@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, "Lijun Ou" <oulijun@huawei.com>,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: RE: [EXT] [PATCH for-next v2 1/4] RDMA/core: Fix return code when modify_port isn't supported
Date: Wed, 16 Oct 2019 08:05:49 +0000 [thread overview]
Message-ID: <MN2PR18MB31825843C5DFA493069485D2A1920@MN2PR18MB3182.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20191016072234.28442-2-kamalheib1@gmail.com>
> From: Kamal Heib <kamalheib1@gmail.com>
> Sent: Wednesday, October 16, 2019 10:23 AM
>
> External Email
>
> ----------------------------------------------------------------------
> The proper return code is "-EOPNOTSUPP" when modify_port callback is not
> supported.
>
> Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/core/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/device.c
> b/drivers/infiniband/core/device.c
> index a667636f74bf..98a01caf7850 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -2397,7 +2397,7 @@ int ib_modify_port(struct ib_device *device,
> port_modify_mask,
> port_modify);
> else
> - rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS;
> + rc = rdma_protocol_roce(device, port_num) ? 0 : -
> EOPNOTSUPP;
This is a bit confusing, looks like for RoCE it's ok not to have a callback but for the
The other protocols it's required. For iWARP for example there also isn't a modify-port.
Is there any other protocol except ib that this is relevant to ?
If not perhaps modify rdma_protocol_roce(..)? to rdma_protocol_ib(...)? -EOPNOTSUPP : 0?
> return rc;
> }
> EXPORT_SYMBOL(ib_modify_port);
> --
> 2.20.1
next prev parent reply other threads:[~2019-10-16 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 7:22 [PATCH for-next v2 0/4] RDMA: modify_port improvements Kamal Heib
2019-10-16 7:22 ` [PATCH for-next v2 1/4] RDMA/core: Fix return code when modify_port isn't supported Kamal Heib
2019-10-16 8:05 ` Michal Kalderon [this message]
2019-10-17 9:09 ` [EXT] " Kamal Heib
2019-10-17 9:14 ` Michal Kalderon
2019-10-18 9:12 ` Kamal Heib
2019-10-16 7:22 ` [PATCH for-next v2 2/4] RDMA/hns: Remove unsupported modify_port callback Kamal Heib
2019-10-16 7:22 ` [PATCH for-next v2 3/4] RDMA/ocrdma: " Kamal Heib
2019-10-16 7:22 ` [PATCH for-next v2 4/4] RDMA/qedr: " Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB31825843C5DFA493069485D2A1920@MN2PR18MB3182.namprd18.prod.outlook.com \
--to=mkalderon@marvell.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.