From: Michael Kelley <mikelley@microsoft.com>
To: Andres Beltran <t-mabelt@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"parri.andrea@gmail.com" <parri.andrea@gmail.com>
Subject: RE: [PATCH v4 1/3] Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening
Date: Mon, 6 Jul 2020 16:28:13 +0000 [thread overview]
Message-ID: <MW2PR2101MB105242B7566BDBB86D58D825D7690@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200701001221.2540-2-lkmlabelt@gmail.com>
From: Andres Beltran <lkmlabelt@gmail.com> Sent: Tuesday, June 30, 2020 5:12 PM
>
> Currently, VMbus drivers use pointers into guest memory as request IDs
> for interactions with Hyper-V. To be more robust in the face of errors
> or malicious behavior from a compromised Hyper-V, avoid exposing
> guest memory addresses to Hyper-V. Also avoid Hyper-V giving back a
> bad request ID that is then treated as the address of a guest data
> structure with no validation. Instead, encapsulate these memory
> addresses and provide small integers as request IDs.
>
> Signed-off-by: Andres Beltran <lkmlabelt@gmail.com>
> ---
> Changes in v4:
> - Use channel->rqstor_size to check if rqstor has been
> initialized.
> Changes in v3:
> - Check that requestor has been initialized in
> vmbus_next_request_id() and vmbus_request_addr().
> Changes in v2:
> - Get rid of "rqstor" variable in __vmbus_open().
>
> drivers/hv/channel.c | 158 +++++++++++++++++++++++++++++++++++++++++
> include/linux/hyperv.h | 21 ++++++
> 2 files changed, 179 insertions(+)
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
next prev parent reply other threads:[~2020-07-06 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 0:12 [PATCH v4 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening Andres Beltran
2020-07-01 0:12 ` [PATCH v4 1/3] Drivers: hv: vmbus: Add " Andres Beltran
2020-07-06 16:28 ` Michael Kelley [this message]
2020-07-01 0:12 ` [PATCH v4 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs " Andres Beltran
2020-07-01 16:53 ` Wei Liu
2020-07-02 2:10 ` Martin K. Petersen
2020-07-07 23:47 ` Nathan Chancellor
2020-07-08 9:21 ` Wei Liu
2020-07-08 9:25 ` Wei Liu
2020-07-17 10:45 ` Wei Liu
2020-07-17 13:54 ` Michael Kelley
2020-07-01 0:12 ` [PATCH v4 3/3] hv_netvsc: " Andres Beltran
2020-07-02 15:50 ` [PATCH v4 0/3] Drivers: hv: vmbus: vmbus_requestor data structure " Andrea Parri
2020-07-06 17:11 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR2101MB105242B7566BDBB86D58D825D7690@MW2PR2101MB1052.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=sthemmin@microsoft.com \
--cc=t-mabelt@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.