RE: [PATCH] input/touchscreen: synaptics_tcm_oncell: add driver

From: Marge Yang <Marge.Yang@tw.synaptics.com>
To: "friederhannenheim@riseup.net" <friederhannenheim@riseup.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Scott Lin <scott.lin@tw.synaptics.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vincent Huang <Vincent.huang@tw.synaptics.com>
Subject: RE: [PATCH] input/touchscreen: synaptics_tcm_oncell: add driver
Date: Mon, 1 Apr 2024 06:18:46 +0000	[thread overview]
Message-ID: <MW4PR03MB66512E92870E3700B64B4F8AA33F2@MW4PR03MB6651.namprd03.prod.outlook.com> (raw)
In-Reply-To: <5dcfdc9c77b1dcd73815b8eaec8a4717@riseup.net>

Loop Scott Lin

Scott Lin is responsible for mobile products.

Thanks
Marge Yang

-----Original Message-----
From: friederhannenheim@riseup.net <friederhannenheim@riseup.net> 
Sent: Sunday, March 31, 2024 4:35 AM
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Marge Yang <Marge.Yang@tw.synaptics.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input/touchscreen: synaptics_tcm_oncell: add driver

CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.

On 2024-03-28 18:53, Dmitry Torokhov wrote:
> [ now CCing for real ]
>
> Hi Frieder,
>
> On Wed, Mar 27, 2024 at 10:39:12PM +0100, Frieder Hannenheim wrote:
>> This is a bit of a stripped down and partially reworked driver for 
>> the synaptics_tcm_oncell touchscreen. I based my work off the driver 
>> in the LineageOS kernel found at 
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Linea
>> geOS_android-5Fkernel-5Foneplus-5Fsm8250&d=DwICAg&c=7dfBJ8cXbWjhc0BhI
>> mu8wVIoUFmBzj1s88r8EGyM0UY&r=ddk_91asmhyAjxFmXHNIQZ2mVcW0D_eq4tb4409nZ94&m=2_iuhvyQkYcT-qsozPf_h9irH_AlUtaQ020UAxVQhZ3SuHgXYihgVocHyTV-zNSV&s=FT4Hkpxkhqktmhyz4RWC9lGAD4DvNBS06wQnn4ofQkk&e=  branch lineage-20. The code was originally written by OnePlus developers but I'm not sure how to credit them correctly.
>
> So the first question is: does this device not use Synaptics RMI4 
> protocol?
>
> I am CCing Marge Yang of Synaptics who may shed some light on the kind 
> of touch controller this is.
>
> Thanks.
Hi Dmitri,

the synaptics-s3908 uses a command based protocol whereas rmi4 is register-based (as far as I understand it, I haven't been able to read up on it properly since information on the internet is sparse). So I'm pretty sure that it can not be controlled via rmi4.

Best wishes,
Frieder