From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Paul Barker <paul.barker.ct@bp.renesas.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: "Sergey Shtylyov" <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Re: [PATCH v2 1/2] net: ravb: Always process TX descriptor ring
Date: Wed, 3 Apr 2024 09:28:00 +0000 [thread overview]
Message-ID: <MWHPR1801MB19181555D42FD13C7EE2D8BDD33D2@MWHPR1801MB1918.namprd18.prod.outlook.com> (raw)
In-Reply-To: <b683f659-23c6-42b2-b690-e3684f37cebf@bp.renesas.com>
> From: Paul Barker <paul.barker.ct@bp.renesas.com>
> > AFAIU, TX is processed without any budget. This wont result in rx work
> > starvation if TX traffic is more ?
>
> Quoting the docs in Documentation/networking/napi.rst:
>
> The method takes a ``budget`` argument - drivers can process
> completions for any number of Tx packets but should only process up
> to ``budget`` number of Rx packets.
>
> skb Tx processing should happen regardless of the ``budget``
>
> I take that to mean that the RX work budget running out should not stop
> processing of TX packets.
>
> Other drivers with a combined TX/RX poll function follow the same pattern of
> processing TX packets regardless of RX budget exhaustion, for example see
> ixgbe_poll() which processes TX packets first (in
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c).
ACK. Thanks for pointing out. I had seen some drivers, TX NAPI routines exist to bring fairness to rx and tx.
Just wondering, if there is a lot of tx traffic, would RX budget alone can do fairness among NAPI
Routines.
next prev parent reply other threads:[~2024-04-03 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 14:53 [PATCH v2 1/2] net: ravb: Always process TX descriptor ring Paul Barker
2024-04-02 14:53 ` [PATCH v2 2/2] net: ravb: Always update error counters Paul Barker
2024-04-02 15:50 ` Sergey Shtylyov
2024-04-02 15:49 ` [PATCH v2 1/2] net: ravb: Always process TX descriptor ring Sergey Shtylyov
2024-04-03 3:39 ` Ratheesh Kannoth
2024-04-03 9:02 ` Paul Barker
2024-04-03 9:28 ` Ratheesh Kannoth [this message]
2024-04-04 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1801MB19181555D42FD13C7EE2D8BDD33D2@MWHPR1801MB1918.namprd18.prod.outlook.com \
--to=rkannoth@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.