Re: [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler

From: "Bernard Metzler" <BMT@zurich.ibm.com>
To: "Zhang Qilong" <zhangqilong3@huawei.com>
Cc: <dledford@redhat.com>, <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler
Date: Thu, 29 Oct 2020 07:21:49 +0000	[thread overview]
Message-ID: <OF43CFF7BE.1D4C49D7-ON00258610.00287315-00258610.0028731D@notes.na.collabserv.com> (raw)
In-Reply-To: <20201028122509.47074-1-zhangqilong3@huawei.com>

-----"Zhang Qilong" <zhangqilong3@huawei.com> wrote: -----

>To: <bmt@zurich.ibm.com>, <dledford@redhat.com>, <jgg@ziepe.ca>
>From: "Zhang Qilong" <zhangqilong3@huawei.com>
>Date: 10/28/2020 10:44PM
>Cc: <linux-rdma@vger.kernel.org>
>Subject: [EXTERNAL] [PATCH] RDMA/siw: fix wrong judgment in
>siw_cm_work_handler
>
>The rv cannot be 'EAGAIN' in the previous path, we
>should use '-EAGAIN' to check it. For example:
>
>Call trace:
>->siw_cm_work_handler
>	->siw_proc_mpareq
>		->siw_recv_mpa_rr
>
>Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
>---
> drivers/infiniband/sw/siw/siw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_cm.c
>b/drivers/infiniband/sw/siw/siw_cm.c
>index 66764f7ef072..1f9e15b71504 100644
>--- a/drivers/infiniband/sw/siw/siw_cm.c
>+++ b/drivers/infiniband/sw/siw/siw_cm.c
>@@ -1047,7 +1047,7 @@ static void siw_cm_work_handler(struct
>work_struct *w)
> 					    cep->state);
> 			}
> 		}
>-		if (rv && rv != EAGAIN)
>+		if (rv && rv != -EAGAIN)
> 			release_cep = 1;
> 		break;
> 
>-- 
>2.17.1
>
>

Thanks Zhang, good catch!

Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>