Re: [PATCH] Remove duplicated code in mpath_alloc_prin_response()

From: ding.yemin@zte.com.cn
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: dm-devel@redhat.com, tang.junhui@zte.com.cn, zhang.kai16@zte.com.cn
Subject: Re: [PATCH] Remove duplicated code in mpath_alloc_prin_response()
Date: Mon, 31 Oct 2016 10:03:15 +0800	[thread overview]
Message-ID: <OF4A4409C2.FCA3FBAE-ON4825805D.000B23A2-4825805D.000B4C6F@zte.com.cn> (raw)
In-Reply-To: <4109416b-9d3c-9b31-90bc-1f8695d9aca9@sandisk.com>

[-- Attachment #1.1: Type: text/plain, Size: 1015 bytes --]

Hello Bart,

Thanks for your review. Using calloc() is really better than malloc(). I 
will modify and commit it later.

Thanks,

Ding Yemin.

Bart Van Assche <bart.vanassche@sandisk.com> 
2016-10-28 23:16

收件人
<ding.yemin@zte.com.cn>, Christophe Varoqui 
<christophe.varoqui@opensvc.com>, 
抄送
<tang.junhui@zte.com.cn>, <zhang.kai16@zte.com.cn>, <dm-devel@redhat.com>
主题
Re: [dm-devel] [PATCH] Remove duplicated code in 
mpath_alloc_prin_response()

On 10/25/2016 01:19 AM, ding.yemin@zte.com.cn wrote:
>                }
> +              if (size > 0)
> +              {
> +                              ptr = malloc(size);
> +                              if (ptr)
> +                              {
> +                                              memset(ptr, 0, size);
> +                              }
> +              }
>                return ptr;
>  }

Hello Ding Yemin,

Please use calloc() instead of open coding it.

Thanks,

Bart.

[-- Attachment #1.2: Type: text/html, Size: 2772 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]