From: Biju Das <biju.das.jz@bp.renesas.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Wolfram Sang <wsa@kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jonathan Cameron <jic23@kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v6 3/4] i2c: Enhance i2c_get_match_data()
Date: Fri, 4 Aug 2023 15:20:42 +0000 [thread overview]
Message-ID: <OS0PR01MB5922DE37B04156444E9B904E8609A@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <ZM0QRhrBkdNtZRz5@smile.fi.intel.com>
Hi Andy Shevchenko,
Thanks for the feedback.
> Subject: Re: [PATCH v6 3/4] i2c: Enhance i2c_get_match_data()
>
> On Fri, Aug 04, 2023 at 08:09:14AM +0100, Biju Das wrote:
> > Enhance i2c_get_match_data() for a faster path for device_get_
> > match_data().
>
> Strange wrap, the function name shouldn't have a new line in between :-)
OK. Wrapping is not required, as it is fitting to chars
scripts/checkpatch.pl --strict 0002-i2c-Enhance-i2c_get_match_data.patch
total: 0 errors, 0 warnings, 0 checks, 27 lines checked
0002-i2c-Enhance-i2c_get_match_data.patch has no obvious style problems and is ready for submission.
>
> > While at it, add const to struct i2c_driver to prevent overriding the
> > driver pointer.
>
> ...
>
> > v6:
> > * Separate patch to prepare for better difference for
> > i2c_match_id() changes.
>
> With this it actually should be patch 2 and patch 2 become 3 (there is not
> much difference code wise, but logically this can be applied even without
> the rest).
OK will move to patch#2.
Cheers,
Biju
>
> With the above addressed
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
>
next prev parent reply other threads:[~2023-08-04 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 7:09 [PATCH v6 0/4] Extend device_get_match_data() to struct bus_type Biju Das
2023-08-04 7:09 ` [PATCH v6 1/4] drivers: fwnode: " Biju Das
2023-08-04 14:10 ` Greg Kroah-Hartman
2023-08-04 7:09 ` [PATCH v6 2/4] i2c: i2c-core-of: Convert i2c_of_match_device_sysfs() to non-static Biju Das
2023-08-04 7:09 ` [PATCH v6 3/4] i2c: Enhance i2c_get_match_data() Biju Das
2023-08-04 14:50 ` Andy Shevchenko
2023-08-04 15:20 ` Biju Das [this message]
2023-08-04 7:09 ` [PATCH v6 4/4] i2c: Add i2c_device_get_match_data() callback Biju Das
2023-08-04 14:54 ` Andy Shevchenko
2023-08-04 14:55 ` Andy Shevchenko
2023-08-04 15:23 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922DE37B04156444E9B904E8609A@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.