From: Biju Das <biju.das.jz@bp.renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v4 09/10] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings
Date: Tue, 27 Jul 2021 14:59:49 +0000 [thread overview]
Message-ID: <OS0PR01MB5922E3E91209C78D0302AB4A86E99@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210726223032.GA988259@robh.at.kernel.org>
Hi Rob,
Thanks for the feedback.
> Subject: Re: [PATCH v4 09/10] dt-bindings: usb: renesas,usbhs: Document
> RZ/G2L bindings
>
> On Mon, Jul 19, 2021 at 01:19:37PM +0100, Biju Das wrote:
> > Document RZ/G2L (R9A07G044L) SoC bindings.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v3->v4:
> > * Added maxitems in interrupt property as per Rob's suggestion.
> > v3:
> > * Updated the bindings as per the USBPHY control IP.
> > ---
> > .../bindings/usb/renesas,usbhs.yaml | 22 +++++++++++++++++--
> > 1 file changed, 20 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > index ad73339ffe1d..a85ad392d443 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> > @@ -17,7 +17,9 @@ properties:
> > - const: renesas,rza1-usbhs
> >
> > - items:
> > - - const: renesas,usbhs-r7s9210 # RZ/A2
> > + - enum:
> > + - renesas,usbhs-r7s9210 # RZ/A2
> > + - renesas,usbhs-r9a07g044 # RZ/G2{L,LC}
> > - const: renesas,rza2-usbhs
> >
> > - items:
> > @@ -59,7 +61,8 @@ properties:
> > - description: USB 2.0 clock selector
> >
> > interrupts:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 4
> >
> > renesas,buswait:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > @@ -108,6 +111,21 @@ required:
> > - clocks
> > - interrupts
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,usbhs-r9a07g044
> > + then:
> > + properties:
> > + interrupts:
> > + items:
> > + - description: U2P_IXL_INT
> > + - description: U2P_INT_DMA[0]
> > + - description: U2P_INT_DMA[1]
> > + - description: U2P_INT_DMAERR
>
> else:
> properties:
> interrupts:
> maxItems: 1
OK. Will fix this in next version.
Cheers,
Biju
>
> > +
> > additionalProperties: false
> >
> > examples:
> > --
> > 2.17.1
> >
> >
next prev parent reply other threads:[~2021-07-27 14:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210719121938.6532-1-biju.das.jz@bp.renesas.com>
2021-07-19 12:19 ` [PATCH v4 01/10] dt-bindings: usb: generic-ohci: Document dr_mode property Biju Das
2021-07-19 12:19 ` [PATCH v4 02/10] dt-bindings: usb: generic-ehci: " Biju Das
2021-07-19 12:19 ` [PATCH v4 03/10] dt-bindings: reset: Document RZ/G2L USBPHY Control bindings Biju Das
2021-07-19 15:27 ` Rob Herring
2021-07-20 11:26 ` Biju Das
2021-07-20 16:36 ` Rob Herring
2021-07-20 16:56 ` Biju Das
2021-07-26 22:26 ` Rob Herring
2021-07-19 12:19 ` [PATCH v4 04/10] reset: renesas: Add RZ/G2L usbphy control driver Biju Das
2021-07-27 7:55 ` Biju Das
2021-07-27 13:37 ` Philipp Zabel
2021-07-27 13:53 ` Biju Das
2021-07-27 13:58 ` Philipp Zabel
2021-07-19 12:19 ` [PATCH v4 05/10] arm64: configs: defconfig: Enable RZ/G2L USBPHY " Biju Das
2021-07-19 12:19 ` Biju Das
2021-07-19 12:19 ` [PATCH v4 06/10] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings Biju Das
2021-07-19 12:19 ` [PATCH v4 06/10] dt-bindings: phy: renesas, usb2-phy: " Biju Das
2021-07-26 22:28 ` [PATCH v4 06/10] dt-bindings: phy: renesas,usb2-phy: " Rob Herring
2021-07-26 22:28 ` Rob Herring
2021-07-27 14:58 ` Biju Das
2021-07-27 14:58 ` Biju Das
2021-07-19 12:19 ` [PATCH v4 07/10] phy: renesas: phy-rcar-gen3-usb2: Add OTG support for RZ/G2L Biju Das
2021-07-19 12:19 ` Biju Das
2021-07-19 12:19 ` [PATCH v4 08/10] arm64: dts: renesas: r9a07g044: Add USB2.0 phy and host support Biju Das
2021-07-19 12:19 ` [PATCH v4 09/10] dt-bindings: usb: renesas,usbhs: Document RZ/G2L bindings Biju Das
2021-07-26 22:30 ` Rob Herring
2021-07-27 14:59 ` Biju Das [this message]
2021-07-19 12:19 ` [PATCH v4 10/10] arm64: dts: renesas: r9a07g044: Add USB2.0 device support Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922E3E91209C78D0302AB4A86E99@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.