[cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node

From: patryk.mungai-ndungu.kx@renesas.com (Patryk Mungai Ndungu)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
Date: Mon, 22 Oct 2018 15:42:16 +0000	[thread overview]
Message-ID: <OSBPR01MB2055C493FF40BB0040ADD300E9F40@OSBPR01MB2055.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <HK0PR01MB2979D1B26EEAA6A190587E32E2F40@HK0PR01MB2979.apcprd01.prod.exchangelabs.com>

Hello Nobuhiro-san,

In light of all the previous comments, would you like me to change the [Backported to CIP] tag to describe the changes of the patch, or to get rid of it altogether before I send the patch?

Kind Regards,

Patryk

> -----Original Message-----
> From: cip-dev-bounces at lists.cip-project.org <cip-dev-bounces@lists.cip-
> project.org> On Behalf Of SZ Lin (???)
> Sent: 22 October 2018 07:53
> To: Chris Paterson <Chris.Paterson2@renesas.com>; ????
> <nobuhiro.iwamatsu@miraclelinux.com>
> Cc: cip-dev at lists.cip-project.org
> Subject: Re: [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node
>
> Hi,
>
> > Me too, however for the patches in this series the changes are
> > actually identical to the upstream commits.
> >
> > The intention of [Backport to CIP] was just to split the signed-off
> > tags between upstream and backport committers, as we moved the
> > cherry-picked commit ID to the top of the patch.
>
> According to the guide of submitting patches [1] - "the line between the last
> Signed-off-by header and yours, indicating the nature of your changes", I
> think it is unnecessary to add this comment in this case. Furthermore, it
> doesn't need to split signed-off tags between upstream and backport
> committers in stable kernel [2].
>
> Nevertheless, we can define our policy here if we decided to add this line for
> each CIP patches.
>
> [1] https://www.kernel.org/doc/html/v4.18/process/submitting-
> patches.html
> [2] https://lkml.org/lkml/2018/10/16/595
>
> SZ
>
> >
> > Kind regards, Chris
> >
> > > Patryk, could you please post with changes?
> > >
> > > > Just my two cents.
> > >
> > > Best regards,
> > >   Nobuhiro
> > >
> > > >
> > > > > Signed-off-by: Patryk Mungai
> > > > > <patryk.mungai-ndungu.kx@renesas.com>
> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > ---
> > > > >  arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++
> > > > >  1 file changed, 7 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644
> > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi
> > > > > @@ -93,6 +93,13 @@
> > > > >                 };
> > > > >         };
> > > > >
> > > > > +       pmu {
> > > > > +               compatible = "arm,cortex-a7-pmu";
> > > > > +               interrupts-extended = <&gic GIC_SPI 82
> > > IRQ_TYPE_LEVEL_HIGH>,
> > > > > +                                     <&gic GIC_SPI 83
> > IRQ_TYPE_LEVEL_HIGH>;
> > > > > +               interrupt-affinity = <&cpu0>, <&cpu1>;
> > > > > +       };
> > > > > +
> > > > >         soc {
> > > > >                 compatible = "simple-bus";
> > > > >                 interrupt-parent = <&gic>;
> > > > > --
> > > > > 2.7.4
> > > > >
> > > > > _______________________________________________
> > > > > cip-dev mailing list
> > > > > cip-dev at lists.cip-project.org
> > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > > _______________________________________________
> > > > cip-dev mailing list
> > > > cip-dev at lists.cip-project.org
> > > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> > > _______________________________________________
> > > cip-dev mailing list
> > > cip-dev at lists.cip-project.org
> > > https://lists.cip-project.org/mailman/listinfo/cip-dev
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.