All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] arm64: dts: renesas: revise hsusb's reg size
Date: Fri, 19 Oct 2018 05:13:03 +0000	[thread overview]
Message-ID: <OSBPR01MB2293CA56C2256DA994755297D8F90@OSBPR01MB2293.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdU09fTvuF3kCkN0dJk_S25_KYyL-1OCgPGNQxs=w2YaEw@mail.gmail.com>

Hi Simon-san, Geert-san,

> From: Geert Uytterhoeven, Sent: Wednesday, October 17, 2018 6:35 PM
> 
> Hi Simon,
> 
> On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote:
> > > This patch revises the reg size of each hsusb device node for
> > > r8a7795, r8a7796 and r8a77965.
> > >
> > > Reported-by: Biju Das <biju.das@bp.renesas.com>
> > > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
> > > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node")
> > > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
> > > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks Shimoda-san,
> >
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> >
> > Also, could you let me know if this has any run-time effect?
> > If so perhaps it should be treated as a fix for v4.20 rather than
> > a patch for v4.21.
> 
> Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway.

As Geert-san mentioned, I don't think this patch needs as a fix for v4.20.

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

  parent reply	other threads:[~2018-10-19 13:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  6:04 [PATCH] arm64: dts: renesas: revise hsusb's reg size Yoshihiro Shimoda
2018-10-17  8:57 ` Simon Horman
2018-10-17  9:34   ` Geert Uytterhoeven
2018-10-18 12:40     ` Simon Horman
2018-10-19  5:13     ` Yoshihiro Shimoda [this message]
2018-10-17  9:15 ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB2293CA56C2256DA994755297D8F90@OSBPR01MB2293.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.