Re: [cip-dev] [PATCH RESEND 4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1

From: "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>
To: <wens@csie.org>, <pavel@denx.de>
Cc: <cip-dev@lists.cip-project.org>, <JohnsonCH.Chen@moxa.com>
Subject: Re: [cip-dev] [PATCH RESEND 4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1
Date: Thu, 4 Jun 2020 06:55:38 +0000	[thread overview]
Message-ID: <OSBPR01MB29831550F3393A10777EF21D92890@OSBPR01MB2983.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20200604041745.28886-1-wens@csie.org>

[-- Attachment #1: Type: text/plain, Size: 4370 bytes --]

Hi Wens,

Thanks for your patch!

> -----Original Message-----
> From: Chen-Yu Tsai (Moxa) [mailto:wens@csie.org]
> Sent: Thursday, June 4, 2020 1:18 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de
> Cc: cip-dev@lists.cip-project.org; JohnsonCH.Chen@moxa.com
> Subject: [PATCH RESEND 4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1
> 
> Hi everyone,
> 
> This is part 1 of MOXA's PM / OPP / cpufreq backport series. The whole
> series aims to backport patches related to PM / OPPv2 and cpufreq
> which were included in the v4.4 kernel from TI's SDK. The end goal is
> to include cpufreq-ti and convert am33xx to using it and OPPv2.
> 
> Part 1 here includes patches from the v4.5 cycle, listed in topological
> order:
> 
>     deaa51465105 PM / OPP: Add debugfs support
>     1c4d12de2719 PM / OPP: Add "opp-supported-hw" binding
>     ffdb8cc7a27c PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
>     af87a39a5f7c PM / OPP: Remove 'operating-points-names' binding
>     754dcf35f346 PM / OPP: Rename OPP nodes as opp@<opp-hz>
>     dc4e7b1fa20a PM / OPP: Add missing doc comments
>     7de36b0aa51a PM / OPP: Parse 'opp-supported-hw' binding
>     01fb4d3c39d3 PM / OPP: Parse 'opp-<prop>-<name>' bindings
>     fd8d8e63467c PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties
>     d9de19b1cc01 PM / OPP: Set cpu_dev->id in cpumask first
>     5ff24d601092 PM / OPP: Use snprintf() instead of sprintf()
>     3be3f8f36e73 devicetree: bindings: Add optional dynamic-power-coefficient property
>     f8fa8ae06b8c cpufreq-dt: Supply power coefficient when registering cooling devices
>     929ca89c305a cpufreq-dt: fix handling regulator_get_voltage() result
>     b331bc20d928 cpufreq: cpufreq-dt: avoid uninitialized variable warnings:
> 
> Of these,
> 
>     dc4e7b1fa20a PM / OPP: Add missing doc comments
> 
> was identified as a patch dependency, but otherwise serves no purpose. And
> 
>     d9de19b1cc01 PM / OPP: Set cpu_dev->id in cpumask first
> 
> was found while looking through git logs. Last,
> 
>     3be3f8f36e73 devicetree: bindings: Add optional dynamic-power-coefficient property
> 
> is related to
> 
>     f8fa8ae06b8c cpufreq-dt: Supply power coefficient when registering cooling devices
> 
> All other patches were included from TI's SDK.
> 
> The patches apply cleanly on top of linux-4.4.y-cip. Please have a look.
> 

I have nothing to point out other than the comment on "PM / OPP: Set cpu_dev->id in cpumask first".

> 
> Regards
> ChenYu
> 

Best regards,
  Nobuhiro

> 
> Andrzej Hajda (1):
>   cpufreq-dt: fix handling regulator_get_voltage() result
> 
> Arnd Bergmann (1):
>   cpufreq: cpufreq-dt: avoid uninitialized variable warnings:
> 
> Bartlomiej Zolnierkiewicz (1):
>   PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties
> 
> Pi-Cheng Chen (1):
>   PM / OPP: Set cpu_dev->id in cpumask first
> 
> Punit Agrawal (2):
>   devicetree: bindings: Add optional dynamic-power-coefficient property
>   cpufreq-dt: Supply power coefficient when registering cooling devices
> 
> Viresh Kumar (9):
>   PM / OPP: Add debugfs support
>   PM / OPP: Add "opp-supported-hw" binding
>   PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
>   PM / OPP: Remove 'operating-points-names' binding
>   PM / OPP: Rename OPP nodes as opp@<opp-hz>
>   PM / OPP: Add missing doc comments
>   PM / OPP: Parse 'opp-supported-hw' binding
>   PM / OPP: Parse 'opp-<prop>-<name>' bindings
>   PM / OPP: Use snprintf() instead of sprintf()
> 
>  .../devicetree/bindings/arm/cpus.txt          |  17 +
>  Documentation/devicetree/bindings/opp/opp.txt | 132 +++++--
>  drivers/base/power/opp/Makefile               |   1 +
>  drivers/base/power/opp/core.c                 | 336 +++++++++++++++++-
>  drivers/base/power/opp/cpu.c                  |   3 +-
>  drivers/base/power/opp/debugfs.c              | 219 ++++++++++++
>  drivers/base/power/opp/opp.h                  |  53 ++-
>  drivers/cpufreq/cpufreq-dt.c                  |  29 +-
>  include/linux/pm_opp.h                        |  22 ++
>  9 files changed, 742 insertions(+), 70 deletions(-)
>  create mode 100644 drivers/base/power/opp/debugfs.c
> 
> --
> 2.27.0.rc0

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4693): https://lists.cip-project.org/g/cip-dev/message/4693
Mute This Topic: https://lists.cip-project.org/mt/74665632/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-