All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: "linux-renesas-soc@vger.kernel.org"  <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] mmc: tmio: improve bringing HW to a sane state with MMC_POWER_OFF
Date: Wed, 2 Dec 2020 13:26:05 +0000	[thread overview]
Message-ID: <OSBPR01MB36863540D1934A9BBF423D04D8F30@OSBPR01MB3686.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20201125204953.3344-1-wsa+renesas@sang-engineering.com>

Hi Wolfram-san,

> From: Wolfram Sang, Sent: Thursday, November 26, 2020 5:50 AM
> 
> Further testing of error cases revealed that downgrade is not enough, so
> we need to reset the SCC which is done by calling the custom reset
> function. This reset function can distinguish between the various SDHI
> variants, so protecting the call with MIN_RCAR2 is enough here.
> 
> Fixes: 24ce2d7b8bea ("mmc: tmio: bring tuning HW to a sane state with MMC_POWER_OFF")
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thank you for the patch! I tested on Salvator-XS with R-Car H3
and confirmed that this patch could fix an issue which the SCC hang
issue happened when the mmc_hw_reset() was called. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda


  parent reply	other threads:[~2020-12-02 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 20:49 [PATCH] mmc: tmio: improve bringing HW to a sane state with MMC_POWER_OFF Wolfram Sang
2020-11-26 12:24 ` Ulf Hansson
2020-12-02 13:26 ` Yoshihiro Shimoda [this message]
2020-12-04 14:38 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB36863540D1934A9BBF423D04D8F30@OSBPR01MB3686.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.