From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: "fdmanana@gmail.com" <fdmanana@gmail.com>
Cc: Eryu Guan <guan@eryu.me>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH v2 2/2] btrfs: add test for zone auto reclaim
Date: Thu, 29 Apr 2021 10:05:01 +0000 [thread overview]
Message-ID: <PH0PR04MB74163147612C69B1CD2D1FA39B5F9@PH0PR04MB7416.namprd04.prod.outlook.com> (raw)
In-Reply-To: CAL3q7H6rQt=ecHN=Q3xh0tGsq5fmrkQaCApeusyvYYj0xDjp7g@mail.gmail.com
On 29/04/2021 11:56, Filipe Manana wrote:
> On Thu, Apr 29, 2021 at 10:44 AM Johannes Thumshirn
> <Johannes.Thumshirn@wdc.com> wrote:
>>
>> On 28/04/2021 11:24, Filipe Manana wrote:
>>> The use of _fail is usually discouraged. A simple echo would suffice here.
>>
>>
>> Need to do echo + exit here, otherwise there will be errors in the shell script.
>
> Errors? I don't understand, what kind of errors?
For instance if the block group isn't removed, the dump-tree call will return two
block groups and then this calculation will fail:
new_data_zone=$(get_data_bg)
new_data_zone=$((new_data_zone >> 9))
next prev parent reply other threads:[~2021-04-29 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 8:46 [PATCH v2 0/2] fstests: first few support patches for zoned btrfs Johannes Thumshirn
2021-04-28 8:46 ` [PATCH v2 1/2] common/rc: introduce zone check commands Johannes Thumshirn
2021-04-28 8:46 ` [PATCH v2 2/2] btrfs: add test for zone auto reclaim Johannes Thumshirn
2021-04-28 9:24 ` Filipe Manana
2021-04-29 9:44 ` Johannes Thumshirn
2021-04-29 9:56 ` Filipe Manana
2021-04-29 10:05 ` Johannes Thumshirn [this message]
2021-04-29 10:06 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR04MB74163147612C69B1CD2D1FA39B5F9@PH0PR04MB7416.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.