From: "Liu, Yi L" <yi.l.liu@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Tian, Kevin" <kevin.tian@intel.com>
Subject: RE: [PATCH 5/5] vfio: Use cdev_device_add() instead of device_create()
Date: Wed, 13 Oct 2021 14:15:54 +0000 [thread overview]
Message-ID: <PH0PR11MB565819A305CDFA1BF3181F32C3B79@PH0PR11MB5658.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211013124921.GB2744544@nvidia.com>
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, October 13, 2021 8:49 PM
>
> On Tue, Oct 12, 2021 at 08:57:22AM +0000, Liu, Yi L wrote:
> > > + ret = __vfio_group_get_from_iommu(iommu_group);
> > > + if (ret)
> > > + goto err_unlock;
> > >
> > > - minor = vfio_alloc_group_minor(group);
> > > - if (minor < 0) {
> > > - vfio_group_unlock_and_free(group);
> > > - return ERR_PTR(minor);
> > > + err = cdev_device_add(&group->cdev, &group->dev);
> > > + if (err) {
> > > + ret = ERR_PTR(err);
> > > + goto err_unlock;
> >
> > should this err branch put the vfio_group reference acquired
> > in above __vfio_group_get_from_iommu(iommu_group);?
>
> No, if ret was !NULL then the reference is returned to the caller via
> the err_unlock
>
> This path to cdev_device_add has ret = NULL so there is no reference
> to put back.
oh, yes. only if ret is NULL will go ahead to this place.
Thanks,
Yi Liu
prev parent reply other threads:[~2021-10-13 14:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 23:22 [PATCH 0/5] Update vfio_group to use the modern cdev lifecycle Jason Gunthorpe
2021-10-01 23:22 ` [PATCH 1/5] vfio: Delete vfio_get/put_group from vfio_iommu_group_notifier() Jason Gunthorpe
2021-10-04 22:25 ` Alex Williamson
2021-10-04 22:34 ` Jason Gunthorpe
2021-10-05 4:01 ` Alex Williamson
2021-10-05 16:17 ` Jason Gunthorpe
2021-10-12 6:32 ` Tian, Kevin
2021-10-12 8:51 ` Liu, Yi L
2021-10-01 23:22 ` [PATCH 2/5] vfio: Do not open code the group list search in vfio_create_group() Jason Gunthorpe
2021-10-02 3:19 ` kernel test robot
2021-10-12 6:37 ` Tian, Kevin
2021-10-12 8:52 ` Liu, Yi L
2021-10-01 23:22 ` [PATCH 3/5] vfio: Don't leak a group reference if the group already exists Jason Gunthorpe
2021-10-04 22:25 ` Alex Williamson
2021-10-04 22:36 ` Jason Gunthorpe
2021-10-05 4:01 ` Alex Williamson
2021-10-05 14:45 ` Jason Gunthorpe
2021-10-01 23:22 ` [PATCH 4/5] vfio: Use a refcount_t instead of a kref in the vfio_group Jason Gunthorpe
2021-10-04 22:25 ` Alex Williamson
2021-10-04 22:39 ` Jason Gunthorpe
2021-10-12 7:08 ` Tian, Kevin
2021-10-12 9:04 ` Liu, Yi L
2021-10-01 23:22 ` [PATCH 5/5] vfio: Use cdev_device_add() instead of device_create() Jason Gunthorpe
2021-10-12 8:33 ` Tian, Kevin
2021-10-12 12:05 ` Jason Gunthorpe
2021-10-13 1:07 ` Tian, Kevin
2021-10-12 8:57 ` Liu, Yi L
2021-10-13 12:49 ` Jason Gunthorpe
2021-10-13 14:15 ` Liu, Yi L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB565819A305CDFA1BF3181F32C3B79@PH0PR11MB5658.namprd11.prod.outlook.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.