RE: [PATCH 2/3] dt-bindings: power: reset: add document for renesas-reset driver

From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms@verge.net.au>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH 2/3] dt-bindings: power: reset: add document for renesas-reset driver
Date: Wed, 15 Feb 2017 17:33:47 +0000	[thread overview]
Message-ID: <PS1PR06MB1162A82F35F00D18D5D22FC08A5B0@PS1PR06MB1162.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWdiosERjUm3ZxZiZL90_4j+CrNm9RU9GaPft7AXbN8kA@mail.gmail.com>

Hi Geert,

On Tuesday, February 14, 2017, Geert Uytterhoeven wrote:
> > +Required properties:
> > +  - compatible: must be one or more of the following:
> > +    - "renesas,r7s72100-reset" for the r7s72100 SoC
> > +    - "renesas,wdt-reset"
> > +                This is a fallback for the above renesas,*-reset
> > +entries
> 
> Please use "renesas,r7s72100-wdt". DT describes the hardware (watchdog),
> not the software policy (use it for reset only, as a max. timeout of 125
> ms is too short for a usable watchdog).

I had a look at:

  Documentation/devicetree/bindings/watchdog/renesas-wdt.txt

Which has:

Required properties:
- compatible : Should be "renesas,<soctype>-wdt", and
	       "renesas,rcar-gen3-wdt" as fallback.
	       Examples with soctypes are:
	         - "renesas,r8a7795-wdt" (R-Car H3)
	         - "renesas,r8a7796-wdt" (R-Car M3-W)

So in my 'renesas-reset.txt' should I do:

A. "renesas,r7s72100-wdt", "renesas,rz-wdt"

  or just: 

B. "renesas,r7s72100-wdt"   (no fallback, change the driver to add new SoCs)

Thoughts????

Thank you,
Chris