From: Alan Stern <stern@rowland.harvard.edu>
To: Aaron Lu <aaron.lu@intel.com>
Cc: James Bottomley <JBottomley@parallels.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: sr: use block layer runtime PM
Date: Thu, 5 Sep 2013 10:25:02 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1309051007220.1121-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <52281C16.5040108@intel.com>
On Thu, 5 Sep 2013, Aaron Lu wrote:
> Migrate SCSI Optical Disk Drive(ODD) driver sr to make use of block
> layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is
> simplified as all SCSI devices that implement runtime PM are now request
> based.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> Note that due to ODD will be polled every 2 seconds, for suspend to
> actually happen, the autosuspend_delay can not be set to more than 2
> seconds.
Or the polling delay must be increased.
> Also, make sure to use the util-linux utility of version 2.23.2 or later,
> as there is a bug fix for eject command to correctly update the ODD's
> locked state. If the fix is not applied, after the ODD is ejected with the
> eject command, it will not be able to enter runtime suspend state any
> more due to SCSI EH code will submit a lock door command for the ODD
> right after its parent ATA port is runtime suspended.
> https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=12272030e563201e0b06732d8a87d8cea7157a04
I think this patch will cause a compile warning if you have
CONFIG_PM_RUNTIME set and CONFIG_PM_SLEEP disabled. The
scsi_dev_type_suspend and scsi_dev_type_resume routines will be defined
but not used.
Otherwise it seems okay.
Alan Stern
next prev parent reply other threads:[~2013-09-05 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 5:52 [PATCH] scsi: sr: use block layer runtime PM Aaron Lu
2013-09-05 14:25 ` Alan Stern [this message]
2013-09-06 1:36 ` Aaron Lu
2013-09-06 2:01 ` [PATCH v2] " Aaron Lu
2013-09-06 14:26 ` Alan Stern
2013-09-06 15:00 ` James Bottomley
2013-09-06 15:56 ` Alan Stern
2013-09-07 15:05 ` Aaron Lu
2013-09-07 15:22 ` Alan Stern
2013-09-07 14:45 ` Aaron Lu
2013-09-09 2:01 ` [PATCH v3] " Aaron Lu
2013-10-28 7:27 ` [RESEND PATCH " Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1309051007220.1121-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=JBottomley@parallels.com \
--cc=aaron.lu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.