From: Trent Piepho <xyzzy@speakeasy.org>
To: Jan Nikitenko <jan.nikitenko@gmail.com>
Cc: Antti Palosaari <crope@iki.fi>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump
Date: Thu, 18 Jun 2009 14:00:50 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0906181358390.32713@shell2.speakeasy.net> (raw)
In-Reply-To: <20090618112227.GA9930@nikitenko.systek.local>
On Thu, 18 Jun 2009, Jan Nikitenko wrote:
> Replace printing to magically sized temporal buffer with use of KERN_CONT
temporary not temporal.
> - sprintf(buf2, "%02x ", val);
> + deb_info(KERN_CONT, " %02x", val);
No comma after KERN_CONT
> else
> - strcpy(buf2, "-- ");
> - strcat(buf, buf2);
> + deb_info(KERN_CONT, " --");
No comma after KERN_CONT
Just use printk() instead of deb_info() for the ones that use KERN_CONT.
> if (reg == 0xff)
> break;
> }
> - deb_info("%s\n", buf);
> + deb_info(KERN_CONT "\n");
> return 0;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-06-18 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 22:31 [PATCH] af9015: fix stack corruption bug Jan Nikitenko
2009-06-10 0:06 ` Antti Palosaari
2009-06-18 11:12 ` [PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump Jan Nikitenko
2009-06-18 11:22 ` Jan Nikitenko
2009-06-18 21:00 ` Trent Piepho [this message]
2009-06-19 7:32 ` [PATCH v2] af9015: avoid magically sized temporary " Jan Nikitenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0906181358390.32713@shell2.speakeasy.net \
--to=xyzzy@speakeasy.org \
--cc=crope@iki.fi \
--cc=jan.nikitenko@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.