From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: Arnd Bergmann <arnd@kernel.org>,
"Coelho, Luciano" <luciano.coelho@intel.com>,
Kalle Valo <kvalo@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Beker, Ayala" <ayala.beker@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iwlwifi: mei: fix building iwlmei
Date: Wed, 16 Mar 2022 18:55:41 +0000 [thread overview]
Message-ID: <SA1PR11MB5825D9DDC4F622A9B8FA77B9F2119@SA1PR11MB5825.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220316183617.1470631-1-arnd@kernel.org>
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Building iwlmei without CONFIG_CFG80211 causes a link-time warning:
>
> ld.lld: error: undefined symbol: ieee80211_hdrlen
> >>> referenced by net.c
> >>>
> >>> net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in
> >>> archive drivers/built-in.a
>
> Add an explicit dependency to avoid this. In theory it should not be needed
> here, but it also seems pointless to allow IWLMEI for configurations without
> CFG80211.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> I see this warning on 5.17-rc8, but did not test it on linux-next, which may
> already have a fix.
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig
> b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 85e704283755..a647a406b87b 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -139,6 +139,7 @@ config IWLMEI
> tristate "Intel Management Engine communication over WLAN"
> depends on INTEL_MEI
> depends on PM
> + depends on CFG80211
> help
> Enables the iwlmei kernel module.
>
FWIW: Luca just merged the exact same patch internally. So
Acked-by: Emmanuel Grumbach <Emmanuel.grumbach@intel.com>
next prev parent reply other threads:[~2022-03-16 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 18:36 [PATCH] iwlwifi: mei: fix building iwlmei Arnd Bergmann
2022-03-16 18:53 ` Kalle Valo
2022-03-16 18:55 ` Grumbach, Emmanuel [this message]
2022-03-17 11:06 ` Coelho, Luciano
2022-03-17 14:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB5825D9DDC4F622A9B8FA77B9F2119@SA1PR11MB5825.namprd11.prod.outlook.com \
--to=emmanuel.grumbach@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ayala.beker@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.