RE: [PATCH v2 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

From: Chris Brandt <Chris.Brandt@renesas.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms@verge.net.au>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks
Date: Wed, 18 Jan 2017 14:53:35 +0000	[thread overview]
Message-ID: <SG2PR06MB116502E2943B5A23E56F65A58A7F0@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20170117203017.r3g43scvrkwpe6kt@ninjato>

Hi Wolfram,

On Tuesday, January 17, 2017, Wolfram Sang wrote:
> Hi Chris,
> 
> > +	struct clk *clk2;
> 
> I'd vote for 'clk_cd' since we are explicitly requesting that clock for it.
> 
> > +	ret = clk_prepare_enable(priv->clk2);
> > +	if (ret < 0)
> > +		return ret;
> 
> You need to disable clk when failing.
> 
> Regards,
> 
>    Wolfram

Thanks for the feedback. I will make those changes.

Chris