RE: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree

From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 2/3] ARM: dts: r7s72100: add ostm to device tree
Date: Sun, 22 Jan 2017 14:13:08 +0000	[thread overview]
Message-ID: <SG2PR06MB11650A7C8014AB5880E1BED28A730@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXQCqs4bCR8o+BC5ak0rE64bQOEz65udFntcQSRkU6+cw@mail.gmail.com>

Hello Geert,

On Sunday, January 22, 2017, Geert Uytterhoeven wrote:
> > diff --git a/arch/arm/boot/dts/r7s72100.dtsi
> > b/arch/arm/boot/dts/r7s72100.dtsi index d5946df..47b2165 100644
> > --- a/arch/arm/boot/dts/r7s72100.dtsi
> > +++ b/arch/arm/boot/dts/r7s72100.dtsi
> > @@ -505,4 +505,20 @@
> >                 cap-sdio-irq;
> >                 status = "disabled";
> >         };
> > +
> > +       ostm0: ostm@fcfec000 {
> > +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +               reg = <0xfcfec000 0x30>;
> > +               interrupts = <GIC_SPI 102 IRQ_TYPE_EDGE_RISING>;
> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM0>;
> 
> Missing power-domains property:
> 
>         power-domains = <&cpg_clocks>;
> 
> > +               status = "disabled";
> > +       };
> > +
> > +       ostm1: ostm@fcfec400 {
> > +               compatible = "renesas,r7s72100-ostm", "renesas,ostm";
> > +               reg = <0xfcfec400 0x30>;
> > +               interrupts = <GIC_SPI 103 IRQ_TYPE_EDGE_RISING>;
> > +               clocks = <&mstp5_clks R7S72100_CLK_OSTM1>;
> 
> Likewise.

OK. Thank you.

> BTW, they're also missing for the last added device nodes (MMC and SDHI).

OK, I will submit patches for them as well.

Thank you for the review.

Chris