RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

From: Chris Brandt <Chris.Brandt@renesas.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver
Date: Wed, 25 Jan 2017 14:02:49 +0000	[thread overview]
Message-ID: <SG2PR06MB1165831212DE76097BDB8DB78A740@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20170125095603.GE2021@mai>

Hi Daniel,

On Wednesday, January 25, 2017, Daniel Lezcano wrote:
> > Then things work, but I'm back to managing the rollback code manually.
> >
> >
> > Any other ideas on how to get the corresponding platform_device for a
> > DT node?
> 
> No :/
> 
> So up to you.
> 	- CLOCKSOURCE_OF_DECLARE consistent but need rollback
> 	or
> 	- platform_device but with another timer available at early time

As far as I can tell, the rollback functions don't mind if I pass NULL
pointers to them. So with CLOCKSOURCE_OF_DECLARE, my error rollback at
the end of ostm_init is basically:

err:
	if (ret) {
		clk_disable_unprepare(ostm_clk);
		iounmap(ostm->base);
		kfree(ostm);
		return ret;
	}

	return 0;
}

If I go with CLOCKSOURCE_OF_DECLARE, I can at least get rid of the early boot message
"clocksource_probe: no matching clocksources found"

I'll go ahead and send a v4 today with all the changes you suggested.

Thank you for your help.

Regards,
Chris